all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Katsumi Yamaoka <yamaoka@jpl.org>
Cc: 23964@debbugs.gnu.org
Subject: bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers
Date: Fri, 22 Jul 2016 13:11:05 +0200	[thread overview]
Message-ID: <m3a8haorli.fsf@gnus.org> (raw)
In-Reply-To: <b4mk2gegcat.fsf@jpl.org> (Katsumi Yamaoka's message of "Fri, 22 Jul 2016 20:08:42 +0900")

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> I'm not quite sure this is the right approach, but I seem to have
> found the cause and the solution.  `shr-image-fetched', that
> `shr-tag-img' calls, overrides the keymap text property on an
> image with the value that was there before inserting the image,
> that is, nil.  Could you please test this patch?
>
> --- shr.el~	2016-07-21 08:35:17.668496000 +0000
> +++ shr.el	2016-07-22 11:05:56.349491100 +0000
> @@ -937,7 +937,7 @@
>  		(while properties
>  		  (let ((type (pop properties))
>  			(value (pop properties)))
> -		    (unless (memq type '(display image-size))
> +		    (unless (memq type '(display image-size keymap))

Yes, this seems to fix the problem.  Thanks!

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2016-07-22 11:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  6:52 bug#23964: 25.1.50; `+' no longer works on images in Gnus article buffers Lars Ingebrigtsen
2016-07-14  2:09 ` Katsumi Yamaoka
2016-07-20 12:47   ` Lars Ingebrigtsen
2016-07-21  8:46     ` Katsumi Yamaoka
2016-07-22 11:08       ` Katsumi Yamaoka
2016-07-22 11:11         ` Lars Ingebrigtsen [this message]
2016-07-24  8:27         ` Lars Ingebrigtsen
2016-07-24 22:53           ` Katsumi Yamaoka
2016-07-25 18:44             ` Lars Ingebrigtsen
2016-07-25 23:50               ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3a8haorli.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=23964@debbugs.gnu.org \
    --cc=yamaoka@jpl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.