From: Lars Ingebrigtsen <larsi@gnus.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: mk.fraggod@gmail.com, npostavs@gmail.com, 31901@debbugs.gnu.org
Subject: bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1
Date: Sun, 22 Jul 2018 16:31:55 +0200 [thread overview]
Message-ID: <m3a7qjpcis.fsf@gnus.org> (raw)
In-Reply-To: <83zhyjweao.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 22 Jul 2018 17:11:43 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> I've fixed this on master, because I'm not 100% sure that my fix is
>> completely correct. Should we perhaps also call a sentinel in the async
>> error case?
>
> But we didn't call the sentinel before, did we?
I don't think we did, but I'm not completely sure. I tried following
the pre-Emacs 26 code flow, and I didn't see a call, but I may be
mistaken.
>> But we should, in any case, perhaps cherry-pick this fix into Emacs
>> 26.2.
>
> It looks like the only visible change in behavior is that we now store
> the error in the process object, is that right?
Yup. That is, it should be unless I messed something up in the
refactoring of report_file_errno. :-)
> If so, I think we want this on emacs-26, yes.
Yup.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2018-07-22 14:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 5:43 bug#31901: Incorrect make-network-process + nowait state handling for non-existing unix sockets in emacs-26.1 Mike Kazantsev
2018-07-01 15:21 ` Noam Postavsky
2018-07-06 8:59 ` Eli Zaretskii
2018-07-14 8:20 ` Eli Zaretskii
2018-07-20 9:16 ` Eli Zaretskii
2018-07-20 10:08 ` Lars Ingebrigtsen
2018-07-20 12:17 ` Eli Zaretskii
2018-07-22 11:40 ` Lars Ingebrigtsen
2018-07-22 14:11 ` Eli Zaretskii
2018-07-22 14:31 ` Lars Ingebrigtsen [this message]
2018-07-22 14:54 ` Mike Kazantsev
2018-07-22 15:23 ` Lars Ingebrigtsen
2018-07-22 15:38 ` Mike Kazantsev
2018-07-22 15:56 ` Eli Zaretskii
2018-07-22 16:42 ` Mike Kazantsev
2018-07-22 16:55 ` Mike Kazantsev
2018-08-06 20:36 ` Noam Postavsky
2018-08-07 15:48 ` Eli Zaretskii
2018-08-08 23:51 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3a7qjpcis.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=31901@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mk.fraggod@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.