all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#35807: 27.0.50; Typo in function name `w32--os-descriptiono'
@ 2019-05-20 12:30 Miciah Dashiel Butler Masters
  2019-05-20 12:35 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 2+ messages in thread
From: Miciah Dashiel Butler Masters @ 2019-05-20 12:30 UTC (permalink / raw)
  To: 35807

While scanning recent changes to the GNU Emacs master branch, I
noticed that http://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/w32-fns.el?id=54f5d678dccdf7b6a60579c6048e8cf87c81c4ae
introduced what appears to be a typo:

 ;;;; System name and version for emacsbug.el

-(defun w32--os-description ()
+(declare-function w32-version "w32-win" ())
+(declare-function w32-read-registry "w32fns" (root key name))
+
+(defun w32--os-descriptiono ()
   "Return a string describing the underlying OS and its version."
   (let* ((w32ver (car (w32-version)))
          (w9x-p (< w32ver 5))

Grepping the Emacs codebase turns up 1 use of `w32--os-description'
(in `report-emacs-bug--os-description') and 0 uses of
`w32--os-descriptiono'.

I believe `w32--os-descriptiono' should be changed back to
`w32--os-description'.

--
Miciah Dashiel Butler Masters <miciah.masters@gmail.com>





^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#35807: 27.0.50; Typo in function name `w32--os-descriptiono'
  2019-05-20 12:30 bug#35807: 27.0.50; Typo in function name `w32--os-descriptiono' Miciah Dashiel Butler Masters
@ 2019-05-20 12:35 ` Lars Ingebrigtsen
  0 siblings, 0 replies; 2+ messages in thread
From: Lars Ingebrigtsen @ 2019-05-20 12:35 UTC (permalink / raw)
  To: Miciah Dashiel Butler Masters; +Cc: 35807

Miciah Dashiel Butler Masters <miciah.masters@gmail.com> writes:

> I believe `w32--os-descriptiono' should be changed back to
> `w32--os-description'.

Yup.  I've now changed the function name back -- thanks for catching this.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-05-20 12:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-20 12:30 bug#35807: 27.0.50; Typo in function name `w32--os-descriptiono' Miciah Dashiel Butler Masters
2019-05-20 12:35 ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.