From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#38599: 27.0.50; org-agenda lists invalid Diary entries Date: Fri, 13 Dec 2019 17:14:16 -0500 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="27169"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Justin Abrahms To: 38599@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Dec 13 23:15:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iftDV-0006wO-UH for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 23:15:22 +0100 Original-Received: from localhost ([::1]:53968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iftDU-0005aV-7K for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Dec 2019 17:15:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37456) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iftDD-0005aI-JB for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:15:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iftDC-0001UY-GD for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56984) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iftDC-0001UH-Co for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iftDC-0000d1-7N for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Dec 2019 22:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 38599 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15762752642347 (code B ref -1); Fri, 13 Dec 2019 22:15:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Dec 2019 22:14:24 +0000 Original-Received: from localhost ([127.0.0.1]:34724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iftCa-0000bn-Ac for submit@debbugs.gnu.org; Fri, 13 Dec 2019 17:14:24 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:41545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iftCY-0000be-TV for submit@debbugs.gnu.org; Fri, 13 Dec 2019 17:14:23 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33238) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iftCX-0005U6-Hh for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iftCW-0000SS-6G for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:21 -0500 Original-Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:39437) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iftCV-0000Ow-RW for bug-gnu-emacs@gnu.org; Fri, 13 Dec 2019 17:14:20 -0500 Original-Received: by mail-qt1-x82a.google.com with SMTP id i12so348837qtp.6 for ; Fri, 13 Dec 2019 14:14:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version; bh=903AmilIO26PmUdb27CMnaS9xhLv2o+GyOjzuSec/wo=; b=x2a0QBzqO5txjM1V+ffFSIj+Wk9ulbMHIgTpHqmcT9xkvzd9p96zonfD0hJr8HliYq W/1+4R1AiOjxCKNn4HFJ75wClaOgmYze7uBq4T+dDj5iDRZwixO/irtrBZpu0BaiGJAR JKMvpqigBm9FvMWJkdIVdBB2Nr1ZpNj/SstIsM4hIfRNLYvy568J/6wjKJpKYnAsDY9E BQe8uI5obEuRp0g3aufc8IQyTYVV4zd4sa03lFONIM8Xx6CHDDhnUzX1r143FASP+w5T mywZBm/fH7UmH1NaM/NldsvgBDgT20MmxFap3unJ6pP2GVeF8BHY6tc5wGGncW+0FGHf EiqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version; bh=903AmilIO26PmUdb27CMnaS9xhLv2o+GyOjzuSec/wo=; b=jNfnfVjM3BR1bCAQImTyyE1A1Z8LoF/Wv+R04RzbSIpknfMD+1D0CVquhHHVTwUDQJ MADxyi+pLRp/ttQRIBJdR5LzIGUxZTeQmuwgfv3aAG//q/cj3gSLkfuYnduLv7McOf6I qxGuK8swwS/huw8OOpcCyDuAB48mPd0FL9MYQO1h9B2vuI6/o8eTr0nlyB1oaeTtiT4Y OQP2QeyVqN9OWYAwAETi/mr1pVGa9bLftR9X8l9Y/mzDevQsIq8QOuvNc237wQcgaftL Uzq7pY5bHOM7nzc9ovRpsqtcvYqWdC9Lb7LSPSBwrjhqPREl237lyFIMvL0KeXXfx+La D5uQ== X-Gm-Message-State: APjAAAU1+j58r/C+omCmi33ad7WqycrOV6MY3A7XzR/RCux0XBOzrDPb OhxWsSQPj+7QkrOSD3E76s+ONoyr31g= X-Google-Smtp-Source: APXvYqzt9Wx47zZYK6jy1snlEL+KA41YuPeH/3ZMmiTgqqCyKqlqQHcSLXsRoNg5+bpNx1G/xJezyQ== X-Received: by 2002:ac8:2bca:: with SMTP id n10mr14823136qtn.251.1576275258783; Fri, 13 Dec 2019 14:14:18 -0800 (PST) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id z6sm3193593qkz.101.2019.12.13.14.14.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2019 14:14:17 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173292 Archived-At: --=-=-= Content-Type: text/plain Hi, Justin reported to me a bug he found while using Excorporate. In Justin's setup, Excorporate retrieves meeting details from a server then writes them to a Diary file. Org agenda reads from that Diary file. In the failing case, the meeting details happened to contain lines whose middles matched diary-time-regexp, e.g. any URL containing 0-9 and then 'h'. Those non-entry lines were displayed as Diary: entries in the Org agenda, when they shouldn't have been. Justin confirmed the attached patch fixes the problem for him. Can an Org mode maintainer review it? Thanks, Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-time-regexp-in-org-get-entries-from-diary.patch >From 938be223a8bfd75df61a703d392d2154b6c479c4 Mon Sep 17 00:00:00 2001 From: Thomas Fitzsimmons Date: Fri, 13 Dec 2019 15:57:28 -0500 Subject: [PATCH] Fix time regexp in org-get-entries-from-diary * lisp/org/org-agenda.el (org-get-entries-from-diary): Make time regular expression more precise. Reported-by: Justin Abrahms --- lisp/org/org-agenda.el | 1 + 1 file changed, 1 insertion(+) diff --git a/lisp/org/org-agenda.el b/lisp/org/org-agenda.el index 2404ca43dc..05c35b8ac3 100644 --- a/lisp/org/org-agenda.el +++ b/lisp/org/org-agenda.el @@ -5135,6 +5135,7 @@ org-get-entries-from-diary (cons 'org-diary-default-entry diary-list-entries-hook)) (diary-file-name-prefix nil) ; turn this feature off (diary-modify-entry-list-string-function 'org-modify-diary-entry-string) + (diary-time-regexp (concat "^" diary-time-regexp)) entries (org-disable-agenda-to-diary t)) (save-excursion -- 2.24.0 --=-=-=--