bug#17325: 24.3.90; can not font-lock @ function

bug#17325: 24.3.90; can not font-lock @ function

[Leo Liu]

Try this code snippet in emacs-lisp-mode and you should see the function
name after @ not font-locked:

(defun who-@-how ()
  )

bug#17325: 24.3.90; can not font-lock @ function

[Stefan Monnier]

> Try this code snippet in emacs-lisp-mode and you should see the function
> name after @ not font-locked:
> (defun who-@-how ()
>   )


That's because of its "prefix" syntax for use in ,@.
I guess we could change its syntax from "'" to "_ p".
Can someone try it out and install that change if it seems to work well?


        Stefan

bug#17325: 24.3.90; can not font-lock @ function

[Leo Liu]

On 2014-04-23 10:52 -0400, Stefan Monnier wrote:
> That's because of its "prefix" syntax for use in ,@.
> I guess we could change its syntax from "'" to "_ p".
> Can someone try it out and install that change if it seems to work well?

Seems to work well. Since this is a regression, I suppose it should be
in emacs-24? If so I'll take care of this tomorrow.

Leo

bug#17325: 24.3.90; can not font-lock @ function

[Stefan Monnier]

>> That's because of its "prefix" syntax for use in ,@.
>> I guess we could change its syntax from "'" to "_ p".
>> Can someone try it out and install that change if it seems to work well?
> Seems to work well. Since this is a regression, I suppose it should be
> in emacs-24? If so I'll take care of this tomorrow.

Not sure why you think it's a regression, but yes you can install it in
emacs-24.


        Stefan

bug#17325: 24.3.90; can not font-lock @ function

[Leo Liu]

On 2014-04-23 13:35 -0400, Stefan Monnier wrote:
> Not sure why you think it's a regression, but yes you can install it in
> emacs-24.

I mean the code snippet is font-locked correctly in 24.3.

BTW, in emacs-lisp-mode-syntax-table why are all entries end with some
whitespaces i.e. instead of

        (modify-syntax-entry ?@ "'" table)

it uses:

        (modify-syntax-entry ?@ "'   " table)

Leo

bug#17325: 24.3.90; can not font-lock @ function

[Stefan Monnier]

>> Not sure why you think it's a regression, but yes you can install it in
>> emacs-24.
> I mean the code snippet is font-locked correctly in 24.3.

Aha, didn't realize that.  Not sure why that changed.

> BTW, in emacs-lisp-mode-syntax-table why are all entries end with some
> whitespaces i.e. instead of
>         (modify-syntax-entry ?@ "'" table)
> it uses:
>         (modify-syntax-entry ?@ "'   " table)

It makes no difference, but this style was very common.  It's probably
because syntax strings are "positional" (the first char has a meaning,
the second another one, the rest yet another) so using "'   " is saying
explicitly "no p/b/1/2/3/4".


        Stefan

bug#17325: 24.3.90; can not font-lock @ function

[Leo Liu]

Fixed in 24.3.91

On 2014-04-24 09:20 -0400, Stefan Monnier wrote:
> It makes no difference, but this style was very common.  It's probably
> because syntax strings are "positional" (the first char has a meaning,
> the second another one, the rest yet another) so using "'   " is saying
> explicitly "no p/b/1/2/3/4".

Thanks for this info.

Leo