From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.bugs Subject: bug#20193: 25.0.50; declarative type specification for D-Bus args Date: Wed, 02 Sep 2015 16:24:42 +0900 Message-ID: References: <87bnjgat6z.fsf@gmx.de> <874mp628is.fsf@gmx.de> <87613wkhkm.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441178728 13640 80.91.229.3 (2 Sep 2015 07:25:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Sep 2015 07:25:28 +0000 (UTC) Cc: 20193@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 02 09:25:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZX2Q0-0005rn-FZ for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Sep 2015 09:25:16 +0200 Original-Received: from localhost ([::1]:34516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX2Pv-0007s1-79 for geb-bug-gnu-emacs@m.gmane.org; Wed, 02 Sep 2015 03:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60037) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX2Ps-0007pa-0S for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2015 03:25:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX2Pn-0003F2-6b for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2015 03:25:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:53643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX2Pn-0003El-3B for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2015 03:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZX2Pm-00081G-OI for bug-gnu-emacs@gnu.org; Wed, 02 Sep 2015 03:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daiki Ueno Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Sep 2015 07:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20193 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20193-submit@debbugs.gnu.org id=B20193.144117869730812 (code B ref 20193); Wed, 02 Sep 2015 07:25:02 +0000 Original-Received: (at 20193) by debbugs.gnu.org; 2 Sep 2015 07:24:57 +0000 Original-Received: from localhost ([127.0.0.1]:45853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZX2Pg-00080u-KK for submit@debbugs.gnu.org; Wed, 02 Sep 2015 03:24:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49955) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZX2Pe-00080l-2h for 20193@debbugs.gnu.org; Wed, 02 Sep 2015 03:24:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZX2PZ-00037M-HN for 20193@debbugs.gnu.org; Wed, 02 Sep 2015 03:24:54 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZX2PZ-00037F-Di; Wed, 02 Sep 2015 03:24:49 -0400 Original-Received: from du-a.org ([219.94.251.20]:45492 helo=dhcp-217-92.nrt.redhat.com) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ZX2PY-0006uz-L1; Wed, 02 Sep 2015 03:24:49 -0400 In-Reply-To: <87613wkhkm.fsf@gmx.de> (Michael Albinus's message of "Sun, 30 Aug 2015 15:54:17 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106082 Archived-At: Michael Albinus writes: > Daiki Ueno writes: > >> Sorry, the patch didn't cleanly apply, as I created it with the diff >> option -w. The patch now resides in the scratch/dbusbind-type branch >> for review. > > I've reviewed it, looks OK to me. The only thing not working was the > provided subfeature; I've fixed it in the code. Thanks for the prompt review. I was actually not sure about the standard usage of subfeatures, and copied the logic from process.c, where they are defined as a plist, so they can be tested as: (featurep 'make-network-process '(:server t)) instead of: (featurep 'make-network-process :server) > The same subfeature shall be provided also for dbus.el; users don't > care about dbusbind.c. That is a good idea. > In dbus.texi I have fixed a small error in your example, and I have > added a note how to test the subfeature. > > I've committed my changes to the branch. If nobody else objects, you > might merge it into master. Thanks for all the fixups. >> By the way, for testing, I tend to think there could be a debugging >> interface, which converts a Lisp expression to a D-Bus message and >> vice-versa. > > Additionally, it might be helpful if you could add some tests to > test/automated/dbus-tests.el. I am working on this, but it is turning to be non-trivial. So, I have pushed it to a separate branch scratch/dbusbind-type-tests, branched off from scratch/dbusbind-type. Regards, -- Daiki Ueno