From: Daiki Ueno <ueno@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 20193@debbugs.gnu.org
Subject: bug#20193: 25.0.50; declarative type specification for D-Bus args
Date: Wed, 02 Sep 2015 16:24:42 +0900 [thread overview]
Message-ID: <m38u8pl1vp.fsf-ueno@gnu.org> (raw)
In-Reply-To: <87613wkhkm.fsf@gmx.de> (Michael Albinus's message of "Sun, 30 Aug 2015 15:54:17 +0200")
Michael Albinus <michael.albinus@gmx.de> writes:
> Daiki Ueno <ueno@gnu.org> writes:
>
>> Sorry, the patch didn't cleanly apply, as I created it with the diff
>> option -w. The patch now resides in the scratch/dbusbind-type branch
>> for review.
>
> I've reviewed it, looks OK to me. The only thing not working was the
> provided subfeature; I've fixed it in the code.
Thanks for the prompt review. I was actually not sure about the
standard usage of subfeatures, and copied the logic from process.c,
where they are defined as a plist, so they can be tested as:
(featurep 'make-network-process '(:server t))
instead of:
(featurep 'make-network-process :server)
> The same subfeature shall be provided also for dbus.el; users don't
> care about dbusbind.c.
That is a good idea.
> In dbus.texi I have fixed a small error in your example, and I have
> added a note how to test the subfeature.
>
> I've committed my changes to the branch. If nobody else objects, you
> might merge it into master.
Thanks for all the fixups.
>> By the way, for testing, I tend to think there could be a debugging
>> interface, which converts a Lisp expression to a D-Bus message and
>> vice-versa.
>
> Additionally, it might be helpful if you could add some tests to
> test/automated/dbus-tests.el.
I am working on this, but it is turning to be non-trivial. So, I have
pushed it to a separate branch scratch/dbusbind-type-tests, branched off
from scratch/dbusbind-type.
Regards,
--
Daiki Ueno
next prev parent reply other threads:[~2015-09-02 7:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-25 3:31 bug#20193: 25.0.50; declarative type specification for D-Bus args Daiki Ueno
2015-03-26 11:34 ` Michael Albinus
2015-03-27 7:29 ` Daiki Ueno
2015-03-27 7:40 ` Michael Albinus
2015-08-27 9:23 ` Daiki Ueno
2015-08-28 7:31 ` Daiki Ueno
2015-08-28 8:22 ` Michael Albinus
2015-08-30 13:54 ` Michael Albinus
2015-09-02 7:24 ` Daiki Ueno [this message]
2015-09-02 14:06 ` Michael Albinus
2015-09-03 9:29 ` Daiki Ueno
2015-09-03 10:07 ` Michael Albinus
2015-09-04 2:33 ` Daiki Ueno
2015-09-04 7:29 ` Michael Albinus
2020-09-18 13:23 ` Lars Ingebrigtsen
2020-09-24 13:17 ` Michael Albinus
2015-09-03 16:08 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38u8pl1vp.fsf-ueno@gnu.org \
--to=ueno@gnu.org \
--cc=20193@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.