From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.bugs Subject: bug#35645: Fix icalendar--add-diary-entry/diary-make-entry interaction Date: Fri, 07 Jun 2019 08:37:18 -0400 Message-ID: References: <874l5xhp0e.fsf@gmail.com> <87r28a4j4a.fsf@panama> <83a7etrbsr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="33621"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 35645@debbugs.gnu.org, npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 07 14:39:54 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.47]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hZE9x-0008cK-0r for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2019 14:39:53 +0200 Original-Received: from localhost ([::1]:50634 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZE9w-0000tU-1X for geb-bug-gnu-emacs@m.gmane.org; Fri, 07 Jun 2019 08:39:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50278) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hZE8O-0007tC-2q for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 08:38:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hZE8G-0006I2-KX for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 08:38:11 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37955) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hZE8A-00068x-2L for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 08:38:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hZE89-0002xS-Ry for bug-gnu-emacs@gnu.org; Fri, 07 Jun 2019 08:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Fitzsimmons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jun 2019 12:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35645 X-GNU-PR-Package: emacs Original-Received: via spool by 35645-submit@debbugs.gnu.org id=B35645.155991105211335 (code B ref 35645); Fri, 07 Jun 2019 12:38:01 +0000 Original-Received: (at 35645) by debbugs.gnu.org; 7 Jun 2019 12:37:32 +0000 Original-Received: from localhost ([127.0.0.1]:51499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZE7g-0002wl-1G for submit@debbugs.gnu.org; Fri, 07 Jun 2019 08:37:32 -0400 Original-Received: from mail-io1-f42.google.com ([209.85.166.42]:39905) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hZE7d-0002wV-RO for 35645@debbugs.gnu.org; Fri, 07 Jun 2019 08:37:31 -0400 Original-Received: by mail-io1-f42.google.com with SMTP id r185so1266103iod.6 for <35645@debbugs.gnu.org>; Fri, 07 Jun 2019 05:37:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fitzsim-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ywAxNDfC07+Yju9pHTUgT+q38/5tCClRFNVbvmOnZU4=; b=DIjIb1Q6P16mMK5OHvtAOTL4AGyZ89so8bmZCvgm82Tp7yOsnk+P2/iQ1yLuK1Wens +NTrBVh0ZrO5E4EOOz3Jaiy7VZDKcIyN6gyb5bUzXVY7wEfki5KE9AtePRpR4U/5Tw+j brG5Imr4K6dQAZSiiUytj+t69qlfhgq9dgktqUTYuW948jiHagKNCE2ZJZ/iuojbfhY5 JznZjjjc1ePozwTHKmSyFrgF/xvhx1u1Gl8iOIOpyzogo/l4rmhG4+68fxrdHx3Wyaoa 5m9DB2Sb+OyGz/oZUooe6yeMREuBQ2X/q571nY/riZkM2hvTlrndQ1Jv3git/2S3zqKL hjlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ywAxNDfC07+Yju9pHTUgT+q38/5tCClRFNVbvmOnZU4=; b=Q0qtWsHnSFqbbP5vdiUfXRx/zefFIRcTjxdNW9HJg7eUXN/5W4a53aJ/p6uqDEOcjn Grtbc1ttAsOvNoM/IKtPM64dbVcQRWHMGrDKFB0c8Yr+yvRpXQxxcLfuIQJpbWRqM56Z +OdvQlVGP/28keAQv3A+qwLo8wK0sYZsk4gRsfo13IXULgJ0Wx+v87Ciu3B4kFU43VAt IS0p2CjNtsOU3KpLdfRyn4ZdLjRUnyLqOMwyXX4KQonr4iEadDbJLoacCmIvXcgmjFtB 7aDqVpb9uPvd+ty4aoPAFb9HDHYfpWn1c6zutll0JHkDa/QzCFU4/EPBpXhJgQ4mjs1C wXFg== X-Gm-Message-State: APjAAAX3ok8kkAC0pCU9kyLL69SaRxaByd/7Ln4R6+tUCTXQawt4INR7 lyx5lIJJUefFhh/5hhwk6e/28Q== X-Google-Smtp-Source: APXvYqygdZumexGH3Ai7TpD8ODrtY6oCmQvfifrJUUgdU7KJBvnYt5RAASibtjEhcNQIbKPQYvqPYg== X-Received: by 2002:a5d:9d97:: with SMTP id 23mr32660844ion.204.1559911040178; Fri, 07 Jun 2019 05:37:20 -0700 (PDT) Original-Received: from localhost.localdomain (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by smtp.gmail.com with ESMTPSA id d75sm802220itd.10.2019.06.07.05.37.18 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 07 Jun 2019 05:37:19 -0700 (PDT) In-Reply-To: <83a7etrbsr.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 07 Jun 2019 12:21:08 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160214 Archived-At: Eli Zaretskii writes: >> From: Ulf Jasper >> Date: Mon, 03 Jun 2019 20:30:13 +0200 >> Cc: 35645@debbugs.gnu.org, Noam Postavsky >> >> Am 23.05.2019 um 22:49 (-0400) schrieb Thomas Fitzsimmons: >> > >> > Ulf, the only other feedback I have for icalendar is that >> > icalendar--add-diary-entry is useful to/used by other packages (e.g., >> > Excorporate) despite it being a private function. What if we added a >> > public alias, icalendar-add-diary-entry, within this same patch? Then I >> > could check for that alias's existence and only enable the workaround >> > advice for older Emacs versions. >> > >> >> Could you please provide a patch with all the changes we want to make? > > Ping! Thomas, could you please provide a patch as Ulf requested? We > would like to proceed with fixing this issue. I tried out this approach, mostly to try to preserve icalendar--add-diary-entry's current default behaviour of showing the resulting diary buffer. However, I was wrong about icalendar-add-diary-entry being called directly; the icalendar entry point Excorporate calls is icalendar-import-buffer. So I think the original patch is fine as-is, as long as Ulf is OK with the change to icalendar--add-diary-entry's default behaviour, such that it does not show the modified diary file's buffer (which some third party packages might rely on). To determine whether or not to apply the workarounds I'll check the "arity" of diary-make-entry. I'll write the change log and push the patch this evening unless I hear otherwise. Thanks, Thomas