Re: Emacs abort

[storm@cua.dk (Kim F. Storm)]

Martin Fredriksson <m@rfc.se> writes:

> I have now verified the abort also in Linux.  The abort happens when
> invoking outline-minor-mode 'show-all' after a previous 'hide-body',
> when part of the buffer is not visible (scrolled).  The abort only
> happens when using keys, not when invoking with 'M-x show-all'.
>
> The steps to trigger this are:
>
> (1) gdb ./emacs
>      (gdb) run -q
>
> (2) Open apa.txt, select outline minor mode (M-x outline-minor-mode)
>     and go to end of buffer.
>
> (3) Hide body:
>      C-c @ C-t
>
> (4) Go up two lines (previous-line x 2)
>
> (5) Show all (must be done using keys):
>      C-c @ C-a
>


I still cannot make it fail even on GNU/Linux.

Does it fail if you start emacs -Q ?



Does the following patch fix the problem, or does it cause other
problems?

Index: xdisp.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.981
diff -c -r1.981 xdisp.c
*** xdisp.c	16 Feb 2005 23:45:03 -0000	1.981
--- xdisp.c	17 Feb 2005 09:40:56 -0000
***************
*** 13136,13142 ****
        for (; row > first_text_row; --row)
  	{
  	  if (!row->enabled_p || !MATRIX_ROW_DISPLAYS_TEXT_P (row))
! 	    abort ();
  
  	  if (MATRIX_ROW_START_CHARPOS (row) >= last_unchanged_pos_old)
  	    row_found = row;
--- 13140,13146 ----
        for (; row > first_text_row; --row)
  	{
  	  if (!row->enabled_p || !MATRIX_ROW_DISPLAYS_TEXT_P (row))
! 	    break;  /* abort (); */
  
  	  if (MATRIX_ROW_START_CHARPOS (row) >= last_unchanged_pos_old)
  	    row_found = row;

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk