From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: State of VC? Date: Tue, 22 Jan 2008 14:51:05 -0700 Message-ID: References: <20080122164306.3B33C83045C@snark.thyrsus.com> <200801222207.m0MM7rlR014153@sallyv1.ics.uci.edu> Reply-To: Tom Tromey NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1201040884 8534 80.91.229.12 (22 Jan 2008 22:28:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Jan 2008 22:28:04 +0000 (UTC) Cc: "Eric S. Raymond" , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 22 23:28:23 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JHRbO-0006fM-Kh for ged-emacs-devel@m.gmane.org; Tue, 22 Jan 2008 23:28:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHRay-000754-OX for ged-emacs-devel@m.gmane.org; Tue, 22 Jan 2008 17:27:52 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JHRas-00071y-Dq for emacs-devel@gnu.org; Tue, 22 Jan 2008 17:27:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JHRaq-00070C-U5 for emacs-devel@gnu.org; Tue, 22 Jan 2008 17:27:45 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JHRaq-000704-CI for emacs-devel@gnu.org; Tue, 22 Jan 2008 17:27:44 -0500 Original-Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JHRap-0000DW-VD for emacs-devel@gnu.org; Tue, 22 Jan 2008 17:27:44 -0500 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m0MMRbxu004157; Tue, 22 Jan 2008 17:27:37 -0500 Original-Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m0MMRbAP029579; Tue, 22 Jan 2008 17:27:37 -0500 Original-Received: from opsy.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m0MMRaRV023224; Tue, 22 Jan 2008 17:27:36 -0500 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id 751CD378324; Tue, 22 Jan 2008 14:51:05 -0700 (MST) X-Attribution: Tom In-Reply-To: <200801222207.m0MM7rlR014153@sallyv1.ics.uci.edu> (Dan Nicolaescu's message of "Tue\, 22 Jan 2008 14\:07\:53 -0800") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:87319 Archived-At: Tom> There are a few bug reports, some with patches, that were never looked Tom> at. Reviewing those would be a good start. Dan> Pointers? Dan> I only remember one bug: Dan> http://permalink.gmane.org/gmane.emacs.devel/87064 http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00549.html (this patch is probably bogus) http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00267.html http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg00410.html (a patch, not really a bug) I also reported one about use of shrink-window-if-larger-than-buffer and VC, but I don't see it right now. Dan> By this time I think that we can declare the vc-status experiment a Dan> success. It is in decent shape and the code is still very simple and Dan> understandable. Do you agree? I think it has potential, but it is not ready. Dan> ;; - vc-register should register multiple files at a time. The Dan> ;; `register' backend function already supports that. This item is listed twice. Tom> * Make dir-status back end function update the vc-status buffer Tom> asynchronously. This means using a process filter. Dan> I am not yet convinced that we should do this. The discussion on this Dan> was started by your observation that PCL-CVS and psvn "pause" when Dan> updating the display. It would be good to actually investigate and see Dan> what the cause of the "pause" is, and make sure that it can be fixed by Dan> going asynchronous. According to the psvn maintainer it is due to sorting the entries after svn exits. Anyway the experiment is pretty easy. I will try to remember to do it. Tom> * Don't clear vc-status buffer when updating. This means figuring out Tom> how to insert new items into the ewoc at the right point. Dan> We don't need to do this right away an easy stopgap: we can keep a list Dan> of selected items and select them at the time they are inserted. This is not the same if a marked file changes from modified to unmodified. In this case it will disappear from the listing. IMO it is nicer UI for the entries to persist a bit. Tom