From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ari Roponen Newsgroups: gmane.emacs.bugs Subject: bug#7082: 24.0.50; Bug in src/doc.c (Fsnarf_documentation) Date: Tue, 21 Sep 2010 17:39:31 +0300 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1285080083 25032 80.91.229.12 (21 Sep 2010 14:41:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 21 Sep 2010 14:41:23 +0000 (UTC) To: 7082@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 21 16:41:21 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy424-0000mk-JG for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Sep 2010 16:41:21 +0200 Original-Received: from localhost ([127.0.0.1]:51221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oy423-0002kY-Qr for geb-bug-gnu-emacs@m.gmane.org; Tue, 21 Sep 2010 10:41:19 -0400 Original-Received: from [140.186.70.92] (port=44989 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oy41r-0002jD-DA for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:41:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oy41p-0006ch-U5 for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:41:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58172) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy41p-0006cd-Sk for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:41:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Oy3ys-00081v-Kl; Tue, 21 Sep 2010 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ari Roponen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Sep 2010 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.128507987930859 (code B ref -1); Tue, 21 Sep 2010 14:38:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Sep 2010 14:37:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy3yp-00081g-8X for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:37:59 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy3ym-00081Z-Kj for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:37:57 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oy40v-0006TZ-U4 for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:40:29 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:36979) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy40v-0006TU-PG for submit@debbugs.gnu.org; Tue, 21 Sep 2010 10:40:09 -0400 Original-Received: from [140.186.70.92] (port=44693 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oy40j-0002FI-FW for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:40:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oy40c-0006MZ-B7 for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:39:57 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:52025) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oy40c-0006M4-6Y for bug-gnu-emacs@gnu.org; Tue, 21 Sep 2010 10:39:50 -0400 Original-Received: by bwz10 with SMTP id 10so7070473bwz.0 for ; Tue, 21 Sep 2010 07:39:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :message-id:mime-version:content-type; bh=l3E/p+g3/+1pXfMj0EyVdbJoc3zfwmMlDy1Wdg3zp2w=; b=oXSdVADPCmchrDwgqi9s4Q3QEqSf1XY0cZesJ6ip/DV7CtMfXv4zWFjErrZULFaMe0 ZAlCVmVBDQQevZu3kK2eWpIQC2/sDbQgmOjB4MTvjvRPiGLfK2kYttmYWwzSWmPGvAEq hCm2Y3C3gvYU+5xOrLLfK9seY1xuD+fhBxOZs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:mime-version:content-type; b=RHoAk3V7ytkyL04cwXDE5j2qG/J2q7OIwGouBNZz4hwbkG+J2XppDRzdJuwbVYdnq/ GBBamDv7Mtl1nAki0wa7Fsrie4NJlYHce1fJJVWNMDMW0vXDpsYDC1Ii+dn3FCQbrzyW ziuxufM8BPGBD842IBx0fCxyIUzYWIcIrP0OM= Original-Received: by 10.204.126.29 with SMTP id a29mr7934582bks.59.1285079989099; Tue, 21 Sep 2010 07:39:49 -0700 (PDT) Original-Received: from arirop (e82-103-227-224.elisa-laajakaista.fi [82.103.227.224]) by mx.google.com with ESMTPS id s34sm7617142bkk.1.2010.09.21.07.39.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 21 Sep 2010 07:39:40 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 21 Sep 2010 10:38:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40344 Archived-At: Hi, recently compiling Emacs has not worked for me. The compilation always aborts with this error: Loading emacs-lisp/float-sup... Loading vc/vc-hooks... Loading vc/ediff-hook... Loading tooltip... Finding pointers to doc strings... /bin/sh: line 8: 10391 Segmentation fault (core dumped) LC_ALL=C `/bin/pwd`/temacs -batch -l loadup dump make[1]: *** [emacs] Error 1 make[1]: Leaving directory `/usr/local/repos/emacs.git/src' make: *** [src] Error 2 After some debugging, I may have found the cause. I added an assert to Fsnarf_documentation in src/doc.c just before the memcpy and it failed: Assertion `buf + filled < end' failed. This means we should use memmove instead, as it can handle overlapping regions properly. 2010-09-21 Ari Roponen (tiny change) * doc.c (Fsnarf_documentation): Use memmove instead of memcpy as the regions may overlap. diff --git a/src/doc.c b/src/doc.c index f8ab9d0..36f7c0e 100644 --- a/src/doc.c +++ b/src/doc.c @@ -678,7 +678,7 @@ the same file name is found in the `doc-directory'. */) } pos += end - buf; filled -= end - buf; - memcpy (buf, end, filled); + memmove (buf, end, filled); } emacs_close (fd); return Qnil; In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.90.5) of 2010-09-21 on arirop Windowing system distributor `Fedora Project', version 11.0.10899905 configured using `configure '--with-x-toolkit=gtk3' '--with-imagemagick'' -- Ari Roponen