Re: master 2a81c5d 1/2: Confine vc-stay-local to CVS, because it was unusable in SVN.

[Lars Magne Ingebrigtsen <larsi@gnus.org>]

"Eric S. Raymond" <esr@thyrsus.com> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org>:
>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> 
>> > When trying to check in from vc mode, I get the backtrace below.  Since
>> > this is git, I'm not quite sure why it's querying bzr...
>> 
>> I seem to be getting this backtrace whenever I save or open a file.
>> Here's an example:
>
> I think I know why.  Very strange that it's not reproducing here.  I'll
> push an attempted fix momentarily.

edebugging this, the problem is here:

      (when (re-search-forward
             ;; bzr prints paths relative to the repository root.
             (concat "^\\(" vc-bzr-state-words "\\):[ \t\n]+"
                     (regexp-quote (vc-bzr-file-name-relative file))

where that function can return nil:

(defun vc-bzr-file-name-relative (filename)
  "Return file name FILENAME stripped of the initial Bzr repository path."
  (let* ((filename* (expand-file-name filename))
         (rootdir (vc-bzr-root filename*)))
    (when rootdir
         (file-relative-name filename* rootdir))))

And regexp-quote on nil doesn't work very well.

I don't know why this function is called at all, though.  Could it be
some local customisation I have that affects this?  I'll try with emacs -Q.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no