From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Adjust EUDC to use BBDB 3.x Date: Sat, 24 Jan 2015 01:47:53 -0500 Message-ID: References: <87h9vml5l5.fsf@sergiodj.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422082084 27088 80.91.229.3 (24 Jan 2015 06:48:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Jan 2015 06:48:04 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sergio Durigan Junior Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 24 07:48:03 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YEuVn-0004Vu-HU for ged-emacs-devel@m.gmane.org; Sat, 24 Jan 2015 07:48:03 +0100 Original-Received: from localhost ([::1]:34147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEuVm-00064K-RU for ged-emacs-devel@m.gmane.org; Sat, 24 Jan 2015 01:48:02 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEuVj-000644-7v for emacs-devel@gnu.org; Sat, 24 Jan 2015 01:48:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEuVg-0007aa-0F for emacs-devel@gnu.org; Sat, 24 Jan 2015 01:47:59 -0500 Original-Received: from mail-ig0-f179.google.com ([209.85.213.179]:33754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEuVf-0007Zq-SG for emacs-devel@gnu.org; Sat, 24 Jan 2015 01:47:55 -0500 Original-Received: by mail-ig0-f179.google.com with SMTP id l13so1165421iga.0 for ; Fri, 23 Jan 2015 22:47:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=MaDEB/DoIAAFiv2lfzdEstCTJe5rtZagREDy+1GZEo4=; b=FBDBKRBTWp3q1IJwuO5RSGs+2jRk+lTZpbSWQGkIq17tzCgmWKFXKwtX7k2zDhvKgu r4PnynpLha58z5/NYOp6vhQgdl4Iyz+TeGo0lmWsz3SN80D2MHpNu2GQK8foCvKNpw9E eNeHt83/IfPfLNUEh3nN2bMtixfAV3CTxH4BUrWNtA5zWW0120x1IB7W0nfs9wf4HEH+ Rrwp5A+aqwMSfG2pZjZR2p9K343mkWjtxT91udA0GeeslgzrA9/ngk1qNZZfqe53TLvl b3oh28C6E/pEUFyQZEzUp4bCB1CRs/QrETR1Nfd4pZF8Bi6bBvjNuEqemdbqdwE5zS6a 7upg== X-Gm-Message-State: ALoCoQmc9ooWH42ld7FQst1UzSZNVUDOqBzpzXyDLk9M8jtoBFa4h9QvLmfdK4GABJAd6NnuEste X-Received: by 10.50.32.33 with SMTP id f1mr6255350igi.9.1422082074475; Fri, 23 Jan 2015 22:47:54 -0800 (PST) Original-Received: from hp-dv5t (69-165-165-189.dsl.teksavvy.com. [69.165.165.189]) by mx.google.com with ESMTPSA id qj6sm1973375igc.1.2015.01.23.22.47.53 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 23 Jan 2015 22:47:53 -0800 (PST) In-Reply-To: <87h9vml5l5.fsf@sergiodj.net> (Sergio Durigan Junior's message of "Mon, 19 Jan 2015 18:21:26 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.213.179 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181716 Archived-At: Hi Sergio, Sergio Durigan Junior writes: > With the release of BBDB 3.x, EUDC does not work properly anymore. The > reason is because BBDB renamed a few fields internally, and EUDC is > still using the old names. Specifically, the problem happens because of > the 'net' -> 'mail' rename. > > The following patch fixes this issue. I tested it with my current .gnus > configuration, and it works fine. > > I have the copyright assignment on file for contributing with GDB and > binutils, but I still do not have it for Emacs (this is my third patch > to the project IIRC). So I will contact the copyright clerk at FSF and > get it done. Meanwhile, I'd appreciate reviews and comments. This is an issue I've run into as well. I'm concerned that this patch will break compatibility with BBDB 2.x. It looks like the newer distribution releases are starting to package BBDB 3.x (I just checked Fedora), so this may be less of a concern in the future. However, I think it's worth trying to make a patch that supports both. Can you file a bug report for this? Thanks, Thomas