all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Sergio Durigan Junior <sergiodj@sergiodj.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Adjust EUDC to use BBDB 3.x
Date: Sat, 24 Jan 2015 01:47:53 -0500	[thread overview]
Message-ID: <m37fwcu12e.fsf@fitzsim.org> (raw)
In-Reply-To: <87h9vml5l5.fsf@sergiodj.net> (Sergio Durigan Junior's message of "Mon, 19 Jan 2015 18:21:26 -0500")

Hi Sergio,

Sergio Durigan Junior <sergiodj@sergiodj.net> writes:

> With the release of BBDB 3.x, EUDC does not work properly anymore.  The
> reason is because BBDB renamed a few fields internally, and EUDC is
> still using the old names.  Specifically, the problem happens because of
> the 'net' -> 'mail' rename.
>
> The following patch fixes this issue.  I tested it with my current .gnus
> configuration, and it works fine.
>
> I have the copyright assignment on file for contributing with GDB and
> binutils, but I still do not have it for Emacs (this is my third patch
> to the project IIRC).  So I will contact the copyright clerk at FSF and
> get it done.  Meanwhile, I'd appreciate reviews and comments.

This is an issue I've run into as well.

I'm concerned that this patch will break compatibility with BBDB 2.x.
It looks like the newer distribution releases are starting to package
BBDB 3.x (I just checked Fedora), so this may be less of a concern in
the future.  However, I think it's worth trying to make a patch that
supports both.  Can you file a bug report for this?

Thanks,
Thomas



  reply	other threads:[~2015-01-24  6:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 23:21 [PATCH] Adjust EUDC to use BBDB 3.x Sergio Durigan Junior
2015-01-24  6:47 ` Thomas Fitzsimmons [this message]
2015-01-24 23:42   ` Sergio Durigan Junior
2015-01-26 17:11     ` raman
2015-01-26 17:18       ` Thomas Fitzsimmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m37fwcu12e.fsf@fitzsim.org \
    --to=fitzsim@fitzsim.org \
    --cc=emacs-devel@gnu.org \
    --cc=sergiodj@sergiodj.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.