From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#34373: Acknowledgement (26.1; Missing range check in rx-submatch-n) Date: Sun, 23 Jun 2019 20:20:36 +0200 Message-ID: References: <92032ECD-6C45-4820-829F-55194CEC885E@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="254153"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 34373@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 23 20:21:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf774-0013z6-D3 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 20:21:14 +0200 Original-Received: from localhost ([::1]:46292 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf773-00053f-A7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 Jun 2019 14:21:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55170) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hf76s-00053W-UC for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:21:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hf76s-00058q-1j for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hf76r-000581-Ua for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:21:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hf76r-0000eD-Ob for bug-gnu-emacs@gnu.org; Sun, 23 Jun 2019 14:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Jun 2019 18:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34373 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 34373-submit@debbugs.gnu.org id=B34373.15613140432444 (code B ref 34373); Sun, 23 Jun 2019 18:21:01 +0000 Original-Received: (at 34373) by debbugs.gnu.org; 23 Jun 2019 18:20:43 +0000 Original-Received: from localhost ([127.0.0.1]:54558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf76Y-0000dM-N1 for submit@debbugs.gnu.org; Sun, 23 Jun 2019 14:20:42 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:44984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hf76W-0000dA-Kn for 34373@debbugs.gnu.org; Sun, 23 Jun 2019 14:20:41 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hf76S-0000QQ-HS; Sun, 23 Jun 2019 20:20:38 +0200 In-Reply-To: <92032ECD-6C45-4820-829F-55194CEC885E@acm.org> ("Mattias \=\?utf-8\?Q\?Engdeg\=C3\=A5rd\=22's\?\= message of "Thu, 7 Feb 2019 19:08:24 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161155 Archived-At: Mattias Engdeg=C3=A5rd writes: > * lisp/emacs-lisp/rx.el (rx-submatch): Type and range check (Bug#34373). [...] > (defun rx-submatch-n (form) > "Parse and produce code from FORM, which is `(submatch-n N ...)'." > (let ((n (nth 1 form))) > + (unless (and (integerp n) (> n 0)) > + (error "rx `submatch-n' argument must be positive")) This looks like an eminently reasonable sanity check to me, but I'm quite unfamiliar with the rx machinery. Just push the change? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no