From: storm@cua.dk (Kim F. Storm)
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Buffer menu fix
Date: Wed, 07 Sep 2005 01:01:37 +0200 [thread overview]
Message-ID: <m364td2432.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <878xyavuw2.fsf@stupidchicken.com> (Chong Yidong's message of "Tue, 06 Sep 2005 15:49:49 -0400")
Chong Yidong <cyd@stupidchicken.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> The only way I can think of to get around this is to bind to a single
>>> function that tries to re-construct the value of `column' based on
>>> where the mouse was clicked. But that seems like a strange thing to
>>> do -- you're throwing away information that you had (i.e., the value
>>> of `column'), only to do a lot of work find out what it was later on.
> [...]
> It's a giant headache to code.
Not if you use the right approach.
Try this patch (not fully tested, but shows the principle):
*** buff-menu.el 06 Sep 2005 23:52:33 +0200 1.91
--- buff-menu.el 07 Sep 2005 00:57:01 +0200
***************
*** 633,660 ****
(insert m2)))
(forward-line)))))
(defun Buffer-menu-make-sort-button (name column)
(if (equal column Buffer-menu-sort-column) (setq column nil))
(let* ((downname (downcase name))
! (map (make-sparse-keymap))
! (fun `(lambda (&optional e)
! ,(concat "Sort the buffer menu by " downname ".")
! (interactive (list last-input-event))
! (if e (mouse-select-window e))
! (Buffer-menu-sort ,column)))
! (sym (intern (format "Buffer-menu-sort-by-%s-%s" name column))))
! ;; Use a symbol rather than an anonymous function, to make the output of
! ;; C-h k less intimidating.
! (fset sym fun)
! (setq fun sym)
;; This keymap handles both nil and non-nil
;; values for Buffer-menu-use-header-line.
! (define-key map [header-line mouse-1] fun)
! (define-key map [header-line mouse-2] fun)
! (define-key map [mouse-2] fun)
(define-key map [follow-link] 'mouse-face)
! (define-key map "\C-m" fun)
(propertize name
'help-echo (concat
(if Buffer-menu-use-header-line
"mouse-1, mouse-2: sort by "
--- 633,658 ----
(insert m2)))
(forward-line)))))
+ (defun Buffer-menu-sort-by-column (&optional e)
+ "Sort the buffer menu by this column."
+ (interactive "e")
+ (if e (mouse-select-window e))
+ (let ((obj (posn-object (event-start e))))
+ (Buffer-menu-sort (get-text-property (cdr obj) 'column (car obj)))))
+
(defun Buffer-menu-make-sort-button (name column)
(if (equal column Buffer-menu-sort-column) (setq column nil))
(let* ((downname (downcase name))
! (map (make-sparse-keymap)))
;; This keymap handles both nil and non-nil
;; values for Buffer-menu-use-header-line.
! (define-key map [header-line mouse-1] 'Buffer-menu-sort-by-column)
! (define-key map [header-line mouse-2] 'Buffer-menu-sort-by-column)
! (define-key map [mouse-2] 'Buffer-menu-sort-by-column)
(define-key map [follow-link] 'mouse-face)
! (define-key map "\C-m" 'Buffer-menu-sort-by-column)
(propertize name
+ 'column column
'help-echo (concat
(if Buffer-menu-use-header-line
"mouse-1, mouse-2: sort by "
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2005-09-06 23:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-04 19:16 Buffer menu fix Chong Yidong
2005-09-05 3:32 ` Eli Zaretskii
2005-09-05 12:31 ` Chong Yidong
2005-09-05 20:50 ` Eli Zaretskii
2005-09-05 22:18 ` Chong Yidong
2005-09-05 23:16 ` Chong Yidong
2005-09-06 4:39 ` Eli Zaretskii
2005-09-06 8:09 ` Thien-Thi Nguyen
2005-09-06 19:49 ` Chong Yidong
2005-09-06 23:01 ` Kim F. Storm [this message]
2005-09-07 0:08 ` Chong Yidong
2005-09-07 12:07 ` Stefan Monnier
2005-09-07 13:04 ` Kim F. Storm
2005-09-08 6:02 ` Chong Yidong
2005-09-07 23:55 ` Chong Yidong
2005-09-05 7:14 ` Richard M. Stallman
2005-09-05 23:58 ` Nick Roberts
2005-09-06 0:23 ` Chong Yidong
2005-09-06 1:16 ` Nick Roberts
2005-09-06 3:30 ` asdf
2005-09-06 4:15 ` Nick Roberts
2005-09-06 19:17 ` Chong Yidong
2005-09-06 11:22 ` Richard M. Stallman
2005-09-06 19:16 ` Eli Zaretskii
-- strict thread matches above, loose matches on Subject: below --
2005-09-06 9:55 Tomas Zerolo
2005-09-06 21:41 ` Kevin Rodgers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m364td2432.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.