Using strcasecmp in xterm.c

Using strcasecmp in xterm.c

[Kim F. Storm]

In xterm.c, we use strcasecmp here:

struct font_info *
x_query_font (f, fontname)
     struct frame *f;
     register char *fontname;
{
  struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f);
  int i;

  for (i = 0; i < dpyinfo->n_fonts; i++)
    if (dpyinfo->font_table[i].name
	&& (!strcasecmp (dpyinfo->font_table[i].name, fontname)
	    || !strcasecmp (dpyinfo->font_table[i].full_name, fontname)))
      return (dpyinfo->font_table + i);
  return NULL;
}


Shouldn't this use xstricmp which is specifically defined to compare
fontnames according to the comment in xfaces.c ?


/* Like stricmp.  Used to compare parts of font names which are in
   ISO8859-1.  */

int
xstricmp (s1, s2)

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Using strcasecmp in xterm.c

[Kenichi Handa]

In article <m3odqgf4y2.fsf@kfs-l.imdomain.dk>, storm@cua.dk (Kim F. Storm) writes:

> In xterm.c, we use strcasecmp here:

> struct font_info *
> x_query_font (f, fontname)
>      struct frame *f;
>      register char *fontname;
> {
>   struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f);
>   int i;

>   for (i = 0; i < dpyinfo->n_fonts; i++)
>     if (dpyinfo->font_table[i].name
> 	&& (!strcasecmp (dpyinfo->font_table[i].name, fontname)
> 	    || !strcasecmp (dpyinfo->font_table[i].full_name, fontname)))
>       return (dpyinfo->font_table + i);
>   return NULL;
> }


> Shouldn't this use xstricmp which is specifically defined to compare
> fontnames according to the comment in xfaces.c ?

What is the difference between xstricmp and strcasecmp?

---
Kenichi Handa
handa@m17n.org

Re: Using strcasecmp in xterm.c

[Kim F. Storm]

Kenichi Handa <handa@m17n.org> writes:

> In article <m3odqgf4y2.fsf@kfs-l.imdomain.dk>, storm@cua.dk (Kim F. Storm) writes:
>
>> In xterm.c, we use strcasecmp here:
>
>> struct font_info *
>> x_query_font (f, fontname)
>>      struct frame *f;
>>      register char *fontname;
>> {
>>   struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f);
>>   int i;
>
>>   for (i = 0; i < dpyinfo->n_fonts; i++)
>>     if (dpyinfo->font_table[i].name
>> 	&& (!strcasecmp (dpyinfo->font_table[i].name, fontname)
>> 	    || !strcasecmp (dpyinfo->font_table[i].full_name, fontname)))
>>       return (dpyinfo->font_table + i);
>>   return NULL;
>> }
>
>
>> Shouldn't this use xstricmp which is specifically defined to compare
>> fontnames according to the comment in xfaces.c ?
>
> What is the difference between xstricmp and strcasecmp?

I dunno -- but strcasecmp doesn't exist on all systems (I just learned
that), and xstricmp comes with Emacs, so it seems safer to use it.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Using strcasecmp in xterm.c

[Eli Zaretskii]

> From: Kenichi Handa <handa@m17n.org>
> Date: Thu, 07 Dec 2006 20:16:41 +0900
> Cc: emacs-devel@gnu.org
> 
> What is the difference between xstricmp and strcasecmp?

They are identical in the C locale.

Re: Using strcasecmp in xterm.c

[Kenichi Handa]

In article <m364cng8i7.fsf@kfs-l.imdomain.dk>, storm@cua.dk (Kim F. Storm) writes:

>>> Shouldn't this use xstricmp which is specifically defined to compare
>>> fontnames according to the comment in xfaces.c ?
> >
> > What is the difference between xstricmp and strcasecmp?

> I dunno -- but strcasecmp doesn't exist on all systems (I just learned
> that), and xstricmp comes with Emacs, so it seems safer to use it.

Ah, I see.  I've just installed that change.

---
Kenichi Handa
handa@m17n.org