Re: Using strcasecmp in xterm.c

[storm@cua.dk (Kim F. Storm)]

Kenichi Handa <handa@m17n.org> writes:

> In article <m3odqgf4y2.fsf@kfs-l.imdomain.dk>, storm@cua.dk (Kim F. Storm) writes:
>
>> In xterm.c, we use strcasecmp here:
>
>> struct font_info *
>> x_query_font (f, fontname)
>>      struct frame *f;
>>      register char *fontname;
>> {
>>   struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f);
>>   int i;
>
>>   for (i = 0; i < dpyinfo->n_fonts; i++)
>>     if (dpyinfo->font_table[i].name
>> 	&& (!strcasecmp (dpyinfo->font_table[i].name, fontname)
>> 	    || !strcasecmp (dpyinfo->font_table[i].full_name, fontname)))
>>       return (dpyinfo->font_table + i);
>>   return NULL;
>> }
>
>
>> Shouldn't this use xstricmp which is specifically defined to compare
>> fontnames according to the comment in xfaces.c ?
>
> What is the difference between xstricmp and strcasecmp?

I dunno -- but strcasecmp doesn't exist on all systems (I just learned
that), and xstricmp comes with Emacs, so it seems safer to use it.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk