From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Further VC tuning is blocked Date: Sat, 05 Jan 2008 11:09:57 -0700 Message-ID: References: <20080104131749.A4D7E830697@snark.thyrsus.com> Reply-To: Tom Tromey NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1199558442 8580 80.91.229.12 (5 Jan 2008 18:40:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Jan 2008 18:40:42 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Eric S. Raymond" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 05 19:41:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JBDx5-0007EE-F4 for ged-emacs-devel@m.gmane.org; Sat, 05 Jan 2008 19:40:59 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JBDwi-00078o-QB for ged-emacs-devel@m.gmane.org; Sat, 05 Jan 2008 13:40:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JBDwe-00077Y-M9 for emacs-devel@gnu.org; Sat, 05 Jan 2008 13:40:32 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JBDwe-000779-3D for emacs-devel@gnu.org; Sat, 05 Jan 2008 13:40:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JBDwd-000774-UC for emacs-devel@gnu.org; Sat, 05 Jan 2008 13:40:31 -0500 Original-Received: from mx1.redhat.com ([66.187.233.31]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JBDwd-0000q5-If for emacs-devel@gnu.org; Sat, 05 Jan 2008 13:40:31 -0500 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m05IeUIn012305; Sat, 5 Jan 2008 13:40:30 -0500 Original-Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m05IeUuO007624; Sat, 5 Jan 2008 13:40:30 -0500 Original-Received: from opsy.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m05IeTMc011707; Sat, 5 Jan 2008 13:40:29 -0500 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id 19C9D508021; Sat, 5 Jan 2008 11:09:57 -0700 (MST) X-Attribution: Tom In-Reply-To: (Tom Tromey's message of "Fri\, 04 Jan 2008 19\:59\:05 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) X-Scanned-By: MIMEDefang 2.58 on 172.16.52.254 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:86209 Archived-At: >>>>> "Tom" == Tom Tromey writes: Tom> Anyway, I think there's still a bit of room for improvement here. I Tom> think it should be possible to invoke svn a single time for this Tom> particular scenario. This patch seems to achieve that. I didn't update the svn status call in vc-svn-registered. It doesn't seem needed. I removed a call to buffer-disable-undo, because it doesn't do anything and is just confusing -- temporary buffers have undo disabled by default. Unfortunately this barely speeds up my test case. It cut off 2 seconds, down to 318 :-(. Still, IMO it is worth applying. Tom 2008-01-05 Tom Tromey * vc-svn.el (vc-svn-state): Pass --no-ignore to svn. (vc-svn-dir-state): Likewise. Remove call to buffer-disable-undo. *** vc-svn.el 02 Jan 2008 16:11:33 -0700 1.59 --- vc-svn.el 05 Jan 2008 10:48:23 -0700 *************** *** 1,6 **** ;;; vc-svn.el --- non-resident support for Subversion version-control ! ;; Copyright (C) 2003, 2004, 2005, 2006, 2007 Free Software Foundation, Inc. ;; Author: FSF (see vc.el for full credits) ;; Maintainer: Stefan Monnier --- 1,6 ---- ;;; vc-svn.el --- non-resident support for Subversion version-control ! ;; Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008 Free Software Foundation, Inc. ;; Author: FSF (see vc.el for full credits) ;; Maintainer: Stefan Monnier *************** *** 139,145 **** (setq localp (or localp (vc-stay-local-p file))) (with-temp-buffer (cd (file-name-directory file)) ! (vc-svn-command t 0 file "status" (if localp "-v" "-u")) (vc-svn-parse-status file))) (defun vc-svn-state-heuristic (file) --- 139,145 ---- (setq localp (or localp (vc-stay-local-p file))) (with-temp-buffer (cd (file-name-directory file)) ! (vc-svn-command t 0 file "status" (if localp "-v" "-u") "--no-ignore") (vc-svn-parse-status file))) (defun vc-svn-state-heuristic (file) *************** *** 153,160 **** ;; Don't specify DIR in this command, the default-directory is ;; enough. Otherwise it might fail with remote repositories. (with-temp-buffer ! (buffer-disable-undo) ;; Because these buffers can get huge ! (vc-svn-command t 0 nil "status" (if localp "-v" "-u")) (vc-svn-parse-status)))) (defun vc-svn-working-revision (file) --- 153,159 ---- ;; Don't specify DIR in this command, the default-directory is ;; enough. Otherwise it might fail with remote repositories. (with-temp-buffer ! (vc-svn-command t 0 nil "status" (if localp "-v" "-u") "--no-ignore") (vc-svn-parse-status)))) (defun vc-svn-working-revision (file)