Patch to enable dbus by default

Patch to enable dbus by default

[Tom Tromey]

I think dbus support should default to 'on', not 'off'.  If dbus is
not detected, it will not be used, so this patch should not break
anything.

Tom

ChangeLog:
2008-01-27  Tom Tromey  <tromey@redhat.com>

	* configure.in (--with-dbus): Default to enabled.

Index: configure.in
===================================================================
RCS file: /sources/emacs/emacs/configure.in,v
retrieving revision 1.502
diff -u -r1.502 configure.in
--- configure.in	27 Jan 2008 16:06:01 -0000	1.502
+++ configure.in	27 Jan 2008 22:57:46 -0000
@@ -142,7 +137,7 @@
 OPTION_DEFAULT_OFF([carbon],[use Carbon GUI on Mac OS X.  This is unsupported!])
 
 OPTION_DEFAULT_ON([gpm],[don't use -lgpm for mouse support on a GNU/Linux console])
-OPTION_DEFAULT_OFF([dbus],[compile with D-Bus support])
+OPTION_DEFAULT_ON([dbus],[don't compile with D-Bus support])
 
 
 AC_ARG_WITH([pkg-config-prog],dnl

Re: Patch to enable dbus by default

[Nick Roberts]

 > I think dbus support should default to 'on', not 'off'.

I don't really know how to use dbus but this would also presumably be in
keeping with supporting other GNU projects.  GNOME, in this case.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: Patch to enable dbus by default

[Michael Olson]

[-- Attachment #1: Type: text/plain, Size: 1442 bytes --]

Tom Tromey <tromey@redhat.com> writes:

> I think dbus support should default to 'on', not 'off'.  If dbus is
> not detected, it will not be used, so this patch should not break
> anything.

Does anyone have a strong opinion on this?  As I'm interested in Tom's
systray work, and this goes along with it, I'm going to apply this patch
tomorrow, unless we have objections/discussion.

> ChangeLog:
> 2008-01-27  Tom Tromey  <tromey@redhat.com>
>
> 	* configure.in (--with-dbus): Default to enabled.
> Index: configure.in
> ===================================================================
> RCS file: /sources/emacs/emacs/configure.in,v
> retrieving revision 1.502
> diff -u -r1.502 configure.in
> --- configure.in	27 Jan 2008 16:06:01 -0000	1.502
> +++ configure.in	27 Jan 2008 22:57:46 -0000
> @@ -142,7 +137,7 @@
>  OPTION_DEFAULT_OFF([carbon],[use Carbon GUI on Mac OS X.  This is unsupported!])
>
>  OPTION_DEFAULT_ON([gpm],[don't use -lgpm for mouse support on a GNU/Linux console])
> -OPTION_DEFAULT_OFF([dbus],[compile with D-Bus support])
> +OPTION_DEFAULT_ON([dbus],[don't compile with D-Bus support])
>
>  AC_ARG_WITH([pkg-config-prog],dnl

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
          Programmer -- Hobbies: Lisp, HCoop          | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Patch to enable dbus by default

[Tom Tromey]

>>>>> "Michael" == Michael Olson <mwolson@gnu.org> writes:

>> I think dbus support should default to 'on', not 'off'.  If dbus is
>> not detected, it will not be used, so this patch should not break
>> anything.

Michael> Does anyone have a strong opinion on this?  As I'm interested
Michael> in Tom's systray work, and this goes along with it, I'm going
Michael> to apply this patch tomorrow, unless we have
Michael> objections/discussion.

FWIW, the notification bits do need dbus, but they don't actually
require that the Emacs dbus support be enabled.  You can configure
'--without-dbus --with-libnotify'; dbus will still be linked in, just
not visible to elisp.



BTW I've been playing with your test cases some more.  I think we are
seeing generic gtk bug.  This bug seems relevant:

http://bugzilla.gnome.org/show_bug.cgi?id=348971

Perhaps I can make this work by waiting for a size-change signal.  I'm
not sure if this is reliable, though.  Maybe I can have it either wait
for a size-change or a timeout, and throw an error in the timeout
case.

Tom

Re: Patch to enable dbus by default

[Michael Olson]

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

Tom Tromey <tromey@redhat.com> writes:

> I think dbus support should default to 'on', not 'off'.  If dbus is
> not detected, it will not be used, so this patch should not break
> anything.
>
> Tom
>
> ChangeLog:
> 2008-01-27  Tom Tromey  <tromey@redhat.com>
>
> 	* configure.in (--with-dbus): Default to enabled.

I've installed this change.

-- 
       Michael Olson -- FSF Associate Member #652     |
 http://mwolson.org/ -- Jabber: mwolson_at_hcoop.net  |  /` |\ | | |
          Programmer -- Hobbies: Lisp, HCoop          | |_] | \| |_|
Projects: Emacs, Muse, ERC, EMMS, ErBot, DVC, Planner |

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]