Re: [Emacs-diffs] /srv/bzr/emacs/trunk r101135: merge the imagemagick branch to trunk

[joakim@verona.se]

Juanma Barranquero <lekktu@gmail.com> writes:

> A few nitpicks (not related to code, just the merge).
>
> On Thu, Aug 19, 2010 at 09:35, Joakim <joakim@localhost.localdomain> wrote:
>
>> modified:
>>  ChangeLog
>
> There's just a ChangeLog entry, at top level, but the changes should
> be documented in the respective ChangeLogs (src/ChangeLog for src/*
> changes, etc.).
>
>>  configure
>>  doc/lispref/display.texi
>>  etc/NEWS
>>  lisp/image-mode.el
>
> These aren't mentioned in any ChangeLog.
>
>> +2010-06-12 Joakim Verona <joakim@verona.se>
>
> When merging branches, the date of the ChangeLog is the date the merge
> is done, not that of the original changes (that information is
> preserved by the branch history).
>
>> +        * image.c: Add support for ImageMagick. When HAVE_IMAGEMAGICK is
>> +        defined:
>
> Usually that information is conveyed by "[HAVE_IMAGEMAGICK]".
>
>> +        * config.in, Makefile.in, configure.in
>
> These files do not have a change description in the entry.

Ok, Ill try to fix these issues.

>     Juanma
>

--