all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
Cc: 16285@debbugs.gnu.org
Subject: bug#16285: 24.3.50; [PATCH] shr: handle <a> tag with blank error.
Date: Sun, 05 Jan 2014 10:48:18 +0100	[thread overview]
Message-ID: <m361pyn4il.fsf@stories.gnus.org> (raw)
In-Reply-To: <877ganst3f.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Sun, 29 Dec 2013 22:08:04 +0900")

Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com> writes:

>           * net/eww.el (shr-descend): Handle <a> tag with blank error.

I've now fixed this in a different manner.  Your patch would have bugged
out if the empty anchor was the first element in the buffer, so I just
made it insert a "*" if we have an empty anchor.

The anchoring mechanism should perhaps be implemented in a different
way -- markers instead of text properties, for instance?  That way
zero-length anchors would be no problem.  Rewriting it in that way
should probably wait until after the feature freeze, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2014-01-05  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-29 13:08 bug#16285: 24.3.50; [PATCH] shr: handle <a> tag with blank error Kenjiro NAKAYAMA
2014-01-05  9:48 ` Lars Magne Ingebrigtsen [this message]
2014-01-05 11:47   ` Kenjiro NAKAYAMA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m361pyn4il.fsf@stories.gnus.org \
    --to=larsi@gnus.org \
    --cc=16285@debbugs.gnu.org \
    --cc=nakayamakenjiro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.