Re: [Emacs-diffs] xwidget updated (1d8b8a2 -> 5f46725)

[joakim@verona.se]

Ulrich Mueller <ulm@gentoo.org> writes:

>>>>>> On Mon, 29 Dec 2014, joakim  wrote:
>
>>> 3) A few places (for example, xdisp.c:handle_single_display_spec)
>>> process xwidget display elements even on non-GUI frames -- does
>>> that mean xwidget.c will be compiled even in --without-x
>>> configurations of Emacs?  If not, you need to condition that code
>>> on HAVE_WINDOW_SYSTEM, like we do with images, for example.
>
>> No the code shouldn't be compiled  if we dont
>> HAVE_WINDOW_SYSTEM. Thanks for the catch!
>
> Currently compilation in the xwidget branch also fails when configure
> was executed with the --without-xwidgets option:
>
>    In toplevel form:
>    xwidget-test.el:33:7:Error: Symbol's function definition is void: get-buffer-xwidgets
>    Makefile:273: recipe for target 'xwidget-test.elc' failed
>
> Maybe byte-compilation of this file (or of all xwidget*.el) should be
> made conditional on the HAVE_XWIDGETS flag?
>
>>> 12) A question about configuration: are xwidgets only supported in
>>> a GTK3 compiled Emacs, or also in other builds?
>
>> xwidgets were originally developed on GTK2, then ported to GTK3. The
>> code only works on GTK3 now, so theres lots of potential cleanup.
>
>> AFAICS theres no real obstacle for getting xwidgets to work on
>> whatever windowing system. Off screen rendering, and some other
>> things would be needed, but I think most modern toolkits support
>> that.
>
>> OTOH, I think it would perhaps be easier to just use GTK3 on the
>> target build.
>
> Is there any chance to get the code working for lucid or motif? (The
> gtk2 and gtk3 builds still suffer from crashes when an X connection is
> closed in a multi-tty setup.)

I dont know those toolkits very well and I dont know if they support the
required feature of offscreen rendering. At any rate it would be a lot
of work to implement support for another toolkit.


> Ulrich

-- 
Joakim Verona