bug#18397: 24.3; [PATCH] follow-minor-mode now has an indicator in the modeline

bug#18397: 24.3; [PATCH] follow-minor-mode now has an indicator in the modeline

[Dima Kogan]

[-- Attachment #1: Type: text/plain, Size: 82 bytes --]

Hi. Here's a tiny patch to add a modeline indicator when using
follow-minor-mode


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-follow-minor-mode-now-has-an-indicator-in-the-modeli.patch --]
[-- Type: text/x-diff, Size: 693 bytes --]

From fcb11c6bd6b02aa42ff4fe3c62ba5cb2add8cede Mon Sep 17 00:00:00 2001
From: Dima Kogan <dima@secretsauce.net>
Date: Wed, 3 Sep 2014 11:10:38 -0700
Subject: [PATCH] follow-minor-mode now has an indicator in the modeline

---
 lisp/follow.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/follow.el b/lisp/follow.el
index ddb25be..5ab8f10 100644
--- a/lisp/follow.el
+++ b/lisp/follow.el
@@ -414,6 +414,7 @@ This command runs the normal hook `follow-mode-hook'.
 Keys specific to Follow mode:
 \\{follow-mode-map}"
   :keymap follow-mode-map
+  :lighter " Follow"
   (if follow-mode
       (progn
 	(add-hook 'compilation-filter-hook 'follow-align-compilation-windows t t)
-- 
2.0.0

bug#18397: 24.3; [PATCH] follow-minor-mode now has an indicator in the modeline

[Lars Ingebrigtsen]

Dima Kogan <dima@secretsauce.net> writes:

> Hi. Here's a tiny patch to add a modeline indicator when using
> follow-minor-mode
>
>>From fcb11c6bd6b02aa42ff4fe3c62ba5cb2add8cede Mon Sep 17 00:00:00 2001
> From: Dima Kogan <dima@secretsauce.net>
> Date: Wed, 3 Sep 2014 11:10:38 -0700
> Subject: [PATCH] follow-minor-mode now has an indicator in the modeline
>
> ---
>  lisp/follow.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/follow.el b/lisp/follow.el
> index ddb25be..5ab8f10 100644
> --- a/lisp/follow.el
> +++ b/lisp/follow.el
> @@ -414,6 +414,7 @@ This command runs the normal hook `follow-mode-hook'.
>  Keys specific to Follow mode:
>  \\{follow-mode-map}"
>    :keymap follow-mode-map
> +  :lighter " Follow"

This seems like a pretty uncontroversial change, but not all minor modes
(especially the more "global" ones) create a lighter, because that would
be a lot of ... mode line stuff.

I don't use follow mode myself, so I don't know.  Opinions?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#18397: 24.3; [PATCH] follow-minor-mode now has an indicator in the modeline

[Lars Ingebrigtsen]

Dima Kogan <dima@secretsauce.net> writes:

> @@ -414,6 +414,7 @@ This command runs the normal hook `follow-mode-hook'.
>  Keys specific to Follow mode:
>  \\{follow-mode-map}"
>    :keymap follow-mode-map
> +  :lighter " Follow"

This has been added in the meantime, and it's " Fol", apparently:

(define-minor-mode next-error-follow-minor-mode
  "Minor mode for compilation, occur and diff modes.

When turned on, cursor motion in the compilation, grep, occur or diff
buffer causes automatic display of the corresponding source code location."
  :group 'next-error :init-value nil :lighter " Fol"


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no