From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: prj@po.cwru.edu (Paul Jarc) Newsgroups: gmane.emacs.devel Subject: Re: don't process $(LDFLAGS) with prefix-args Date: Fri, 28 Mar 2003 13:08:43 -0500 Organization: What did you have in mind? A short, blunt, human pyramid? Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1048875041 28189 80.91.224.249 (28 Mar 2003 18:10:41 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 28 Mar 2003 18:10:41 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Mar 28 19:10:38 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18yyJK-0007KE-00 for ; Fri, 28 Mar 2003 19:10:38 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18yyLn-000754-00 for ; Fri, 28 Mar 2003 19:13:11 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18yyIt-0005Io-04 for emacs-devel@quimby.gnus.org; Fri, 28 Mar 2003 13:10:11 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18yyIG-0004g4-00 for emacs-devel@gnu.org; Fri, 28 Mar 2003 13:09:32 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18yyHq-000476-00 for emacs-devel@gnu.org; Fri, 28 Mar 2003 13:09:07 -0500 Original-Received: from multivac.student.cwru.edu ([129.22.96.25] helo=multivac.cwru.edu) by monty-python.gnu.org with smtp (Exim 4.10.13) id 18yyHW-0003Ii-00 for emacs-devel@gnu.org; Fri, 28 Mar 2003 13:08:46 -0500 Original-Received: (qmail 28587 invoked by uid 500); 28 Mar 2003 18:09:05 -0000 Original-To: rms@gnu.org In-Reply-To: (prj@po.cwru.edu's message of "Thu, 27 Mar 2003 15:38:29 -0500") Mail-Copies-To: nobody Original-Lines: 40 User-Agent: Gnus/5.090017 (Oort Gnus v0.17) Emacs/21.2 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12715 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12715 I wrote: > The distributed Makefile.in's are similar enough, but somewhere in the > 21.2 build process, Makefile.in is modified like so: Sorry, my mistake. That isn't happening; I had simply patched my 21.2 this way to make it compile. So the bug hasn't reappeared - it was never fixed. :/ ISTR what happened was that I posted this patch for 21.1 or 21.2, and it was agreed that it should be applied, but apparently it never was. It still works for me with 21.3. The patch makes it so the user-supplied LDFLAGS is not processed by YMF_PASS_LDFLAGS. So on systems where $(LD) is $(CC), this patch changes the interpretation of LDFLAGS in src/ to match its interpretation in other subdirectories. On systems where $(LD) is ld, YMF_PASS_LDFLAGS is a no-op, so there is no real change: the interpretation is still inconsistent among subdirectories. --- Makefile.in.2 2003-03-27 14:42:33.000000000 -0500 +++ emacs-21.2/src/Makefile.in 2003-03-27 14:57:21.000000000 -0500 @@ -495,7 +495,7 @@ #endif /* not ORDINARY_LINK */ ALL_LDFLAGS = LD_SWITCH_SYSTEM LD_SWITCH_SYSTEM_TEMACS LD_SWITCH_MACHINE \ - LD_SWITCH_MACHINE_TEMACS LD_SWITCH_SITE $(LDFLAGS) + LD_SWITCH_MACHINE_TEMACS LD_SWITCH_SITE /* A macro which other sections of Makefile can redefine to munge the flags before they're passed to LD. This is helpful if you have @@ -868,7 +868,7 @@ #endif temacs: MAKE_PARALLEL $(LOCALCPP) $(STARTFILES) stamp-oldxmenu ${obj} ${otherobj} OBJECTS_MACHINE prefix-args - $(LD) YMF_PASS_LDFLAGS (${STARTFLAGS} ${ALL_LDFLAGS}) \ + $(LD) YMF_PASS_LDFLAGS (${STARTFLAGS} ${ALL_LDFLAGS}) $(LDFLAGS) \ -o temacs ${STARTFILES} ${obj} ${otherobj} \ OBJECTS_MACHINE ${LIBES} paul