Emacs does not distinguish between `æ' and `C-æ'

Emacs does not distinguish between `æ' and `C-æ'

[Jesper Harder]

My Danish keyboard has an `æ' key.  In Emacs 21.2 `æ' and `C-æ' were
recognized as different key sequences:

(read-key-sequence "")  Input: æ  =>   [230]
(read-key-sequence "")  Input: C-æ  => [134]

This is no longer the case in Emacs 21.3 (and cvs head):

(read-key-sequence "")  Input: æ  =>   [2278]
(read-key-sequence "")  Input: C-æ  => [2278]

This means that I can only bind `æ', but not `C-æ'.


In GNU Emacs 21.3.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2003-04-28 on defun.localdomain
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.iso88591
  locale-coding-system: iso-latin-1
  default-enable-multibyte-characters: t

Re: Emacs does not distinguish between `æ' and `C-æ'

[Stefan Monnier]

> My Danish keyboard has an `æ' key.  In Emacs 21.2 `æ' and `C-æ' were
> recognized as different key sequences:
> (read-key-sequence "")  Input: æ  =>   [230]
> (read-key-sequence "")  Input: C-æ  => [134]
> This is no longer the case in Emacs 21.3 (and cvs head):
> (read-key-sequence "")  Input: æ  =>   [2278]
> (read-key-sequence "")  Input: C-æ  => [2278]
> This means that I can only bind `æ', but not `C-æ'.

I think this is due to the fact that Emacs ignores modifiers on
multibyte-char keys.  It worked before because your key was not recognized
as a multibyte-char key (it was only converted to the proper latin-1 char
when inserting the char in the buffer).  But by fixing this bug, I bumped
into the limitation you're seeing.

The patch below should fix it (applied to both branches).


        Stefan


Index: keyboard.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/keyboard.c,v
retrieving revision 1.741
diff -u -r1.741 keyboard.c
--- keyboard.c	10 May 2003 22:15:35 -0000	1.741
+++ keyboard.c	14 May 2003 18:38:00 -0000
@@ -5013,8 +5013,15 @@
     case MULTIBYTE_CHAR_KEYSTROKE_EVENT:
       {
 	Lisp_Object lispy_c;
+	int c = event->code;
 
-	XSETFASTINT (lispy_c, event->code);
+	/* Add in the other modifier bits.  We took care of ctrl_modifier
+	   just above, and the shift key was taken care of by the X code,
+	   and applied to control characters by make_ctrl_char.  */
+	c |= (event->modifiers
+	      & (meta_modifier | alt_modifier
+		 | hyper_modifier | super_modifier | ctrl_modifier));
+	XSETFASTINT (lispy_c, c);
 	return lispy_c;
       }
 

Re: Emacs does not distinguish between `æ'and `C-æ'

[Andreas Schwab]

"Stefan Monnier" <monnier+gmane.emacs.bugs/news/@rum.cs.yale.edu> writes:

|> Index: keyboard.c
|> ===================================================================
|> RCS file: /cvsroot/emacs/emacs/src/keyboard.c,v
|> retrieving revision 1.741
|> diff -u -r1.741 keyboard.c
|> --- keyboard.c	10 May 2003 22:15:35 -0000	1.741
|> +++ keyboard.c	14 May 2003 18:38:00 -0000
|> @@ -5013,8 +5013,15 @@
|>      case MULTIBYTE_CHAR_KEYSTROKE_EVENT:
|>        {
|>  	Lisp_Object lispy_c;
|> +	int c = event->code;
|>  
|> -	XSETFASTINT (lispy_c, event->code);
|> +	/* Add in the other modifier bits.  We took care of ctrl_modifier
                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|> +	   just above, and the shift key was taken care of by the X code,
|> +	   and applied to control characters by make_ctrl_char.  */
|> +	c |= (event->modifiers
|> +	      & (meta_modifier | alt_modifier
|> +		 | hyper_modifier | super_modifier | ctrl_modifier));

It seems comment and code aren't in line.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."