From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Add M-x occur to the menu-bar Date: 24 Feb 2004 01:37:09 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <3F69E6FF.9050702@yahoo.com> <4n8yjto16h.fsf@collins.bwh.harvard.edu> <4nisixjibl.fsf@collins.bwh.harvard.edu> <20040127230323.GB5407@fencepost> <4n7jzc919v.fsf@collins.bwh.harvard.edu> <4nn085i7nl.fsf@collins.bwh.harvard.edu> <4noese37h0.fsf@collins.bwh.harvard.edu> <4nbrodxwqm.fsf@collins.bwh.harvard.edu> <4n8yjcccvj.fsf@collins.bwh.harvard.edu> <4nwu6sp7ni.fsf@collins.bwh.harvard.edu> Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AvPei-00037N-00 for ; Tue, 24 Feb 2004 00:38:32 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AvPeh-0007qt-00 for ; Tue, 24 Feb 2004 00:38:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvPeD-0007H7-2J for emacs-devel@quimby.gnus.org; Mon, 23 Feb 2004 18:38:01 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1AvPe3-0007Fw-Hj for emacs-devel@gnu.org; Mon, 23 Feb 2004 18:37:51 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1AvPdX-0007Ar-LW for emacs-devel@gnu.org; Mon, 23 Feb 2004 18:37:50 -0500 Original-Received: from [195.41.46.236] (helo=pfepb.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.30) id 1AvPdX-0007Ab-CF for emacs-devel@gnu.org; Mon, 23 Feb 2004 18:37:19 -0500 Original-Received: from kfs-l.imdomain.dk.cua.dk (0x503e2644.bynxx3.adsl-dhcp.tele.dk [80.62.38.68]) by pfepb.post.tele.dk (Postfix) with SMTP id A435A5EE01D; Tue, 24 Feb 2004 00:37:14 +0100 (CET) Original-To: Ted Zlatanov In-Reply-To: <4n3c91k02f.fsf@collins.bwh.harvard.edu> Original-Lines: 36 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20142 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20142 Ted Zlatanov writes: > Here's another version of the next-error patch. Getting closer :-) > What it does: > > - move the next-error framework to simple.el, so it's always loaded. > This was next-error plus all the related functions. > > - make the next-error-function always local (but not buffer-local) The way you use make-local-variable doesn't accomplish that. Either use make-variable-buffer-local at the global level (it will work in this case, as simple.el is pre-loaded. Or use (set (make-local-variable 'next-error-function) 'some-function) everywhere you currently setq next-error-function. > (defun compilation-find-buffer (&optional other-buffer) > ! (let ((next-error-buffer-p compilation-buffer-p)) > ! (next-error-find-buffer other-buffer))) This does not function-bind next-error-buffer-p ... Does it really work? > + (make-local-variable 'next-error-function) -- Kim F. Storm http://www.cua.dk