From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug Date: Mon, 29 May 2006 10:22:13 +0200 Message-ID: References: <87k69eyddj.fsf@lrde.org> <87fyj0r41g.fsf@lrde.org> <20060524112846.GA12046@agmartin.aq.upm.es> <87bqtmjrsh.fsf_-_@lrde.org> <87odxjakox.fsf@lrde.org> <8764jrlewm.fsf@lrde.org> <87pshyqgtd.fsf@lrde.org> <87fyiuq9t5.fsf@lrde.org> <877j45rj3w.fsf@lrde.org> <87odxhq1ah.fsf@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1148891100 28760 80.91.229.2 (29 May 2006 08:25:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 29 May 2006 08:25:00 +0000 (UTC) Cc: Agustin Martin , Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 29 10:24:58 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Fkd3R-0005ZN-GO for ged-emacs-devel@m.gmane.org; Mon, 29 May 2006 10:24:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fkd3Q-0002xz-LK for ged-emacs-devel@m.gmane.org; Mon, 29 May 2006 04:24:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Fkd3A-0002x8-Ct for emacs-devel@gnu.org; Mon, 29 May 2006 04:24:32 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Fkd39-0002w0-Fn for emacs-devel@gnu.org; Mon, 29 May 2006 04:24:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Fkd39-0002va-2J for emacs-devel@gnu.org; Mon, 29 May 2006 04:24:31 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Fkd8f-0006Zf-PN for emacs-devel@gnu.org; Mon, 29 May 2006 04:30:13 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id CED408A0094; Mon, 29 May 2006 10:24:28 +0200 (CEST) Original-To: michael.cadilhac@lrde.org (=?utf-8?Q?Micha=C3=ABl?= Cadilhac) In-Reply-To: <87odxhq1ah.fsf@lrde.org> (=?utf-8?Q?Micha=C3=ABl?= Cadilhac's message of "Sun, 28 May 2006 23:36:54 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55415 Archived-At: michael.cadilhac@lrde.org (Micha=C3=ABl Cadilhac) writes: > But it would be cleaner, indeed, to define the whole thing iff SIGCHLD > is defined. > > I modified the patch for that (including in sigchld_handler and so > because the list is not defined if SIGCHLD is not), and to make the > insertion in deleted_processes_list before the kill. Looking at the code once more, I noticed that sigchld_handler is only installed (i.e. used) if SIGCHLD is defined, but it is defined unconditiona= lly. So conditioning the entire sigchld_handler in #ifdef SIGCHLD would be much= =20 cleaner IMO. And to Eli: I also saw how MS-Windows handles process termination without SIGCHLD. Actually, it would do harm if SIGCHLD was ever defined on MS-Windows, so perhaps we should explicitly add something like this after all includes: /* MS-Windows has its own way of detecting process termination. It does not normally define SIGCHLD, but just in case... */ #ifdef WINDOWSNT #undef SIGCHLD #endif --=20 Kim F. Storm http://www.cua.dk