all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: Agustin Martin <agustin.martin@hispalinux.es>,
	Stefan Monnier <monnier@iro.umontreal.ca>,
	emacs-devel@gnu.org
Subject: Re: delete-process bug
Date: Mon, 29 May 2006 10:22:13 +0200	[thread overview]
Message-ID: <m34pz9s0ju.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <87odxhq1ah.fsf@lrde.org> (Michaël Cadilhac's message of "Sun, 28 May 2006 23:36:54 +0200")

michael.cadilhac@lrde.org (Michaël Cadilhac) writes:

> But it would be cleaner, indeed, to define the whole thing iff SIGCHLD
> is defined.
>
> I modified the patch for that (including in sigchld_handler and so
> because the list is not defined if SIGCHLD is not), and to make the
> insertion in deleted_processes_list before the kill.

Looking at the code once more, I noticed that sigchld_handler is only
installed (i.e. used) if SIGCHLD is defined, but it is defined unconditionally.

So conditioning the entire sigchld_handler in #ifdef SIGCHLD would be much 
cleaner IMO.


And to Eli:

I also saw how MS-Windows handles process termination without SIGCHLD.
Actually, it would do harm if SIGCHLD was ever defined on MS-Windows,
so perhaps we should explicitly add something like this after
all includes:


/* MS-Windows has its own way of detecting process termination.
   It does not normally define SIGCHLD, but just in case...  */
#ifdef WINDOWSNT
#undef SIGCHLD
#endif

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  parent reply	other threads:[~2006-05-29  8:22 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-24 19:36 Ispell loads dict twice Michaël Cadilhac
2006-04-26 10:14 ` Agustin Martin
2006-04-26 21:58   ` Michaël Cadilhac
2006-05-23 18:26 ` Michaël Cadilhac
2006-05-24 11:28   ` Agustin Martin
2006-05-25 10:57     ` delete-process bug (was: Ispell loads dict twice.) Michaël Cadilhac
2006-05-25 12:19       ` Agustin Martin
2006-05-25 14:55       ` delete-process bug Stefan Monnier
2006-05-25 14:59         ` David Kastrup
2006-05-25 15:17         ` Michaël Cadilhac
2006-05-25 15:26           ` David Kastrup
2006-05-25 19:40           ` Stefan Monnier
2006-05-25 23:51         ` Kim F. Storm
2006-05-26  4:49           ` Richard Stallman
2006-05-26 13:03           ` Stefan Monnier
2006-05-26  2:22         ` Richard Stallman
2006-05-26 11:29           ` Michaël Cadilhac
2006-05-27  3:36             ` Richard Stallman
2006-05-26 13:10           ` Stefan Monnier
2006-05-26 17:27             ` Michael Mauger
2006-05-27  9:19               ` Michaël Cadilhac
2006-05-27 14:16                 ` Stefan Monnier
2006-05-27 14:29                   ` Michaël Cadilhac
2006-05-28 16:01                     ` Michaël Cadilhac
2006-05-28 18:00                       ` Stefan Monnier
2006-05-28 18:32                         ` Michaël Cadilhac
2006-05-28 19:48                           ` Stefan Monnier
2006-05-28 20:26                             ` Michaël Cadilhac
2006-05-28 21:15                               ` Kim F. Storm
2006-05-28 21:36                                 ` Michaël Cadilhac
2006-05-28 23:54                                   ` Stefan Monnier
2006-05-29 11:39                                     ` Michaël Cadilhac
2006-05-29  8:22                                   ` Kim F. Storm [this message]
2006-05-29  8:50                                     ` David Kastrup
2006-05-29 19:04                                       ` Eli Zaretskii
2006-05-29 19:27                                     ` Eli Zaretskii
2006-05-29 21:42                                       ` Kim F. Storm
2006-05-29 22:08                                         ` Eli Zaretskii
2006-05-29  3:32                                 ` Eli Zaretskii
2006-05-29  8:14                                   ` Kim F. Storm
2006-05-29 10:59                                     ` Michaël Cadilhac
2006-05-29 19:25                                     ` Eli Zaretskii
2006-05-29 20:04                                       ` Michaël Cadilhac
2006-05-29 21:24                                         ` Eli Zaretskii
2006-05-29 21:42                                           ` Michaël Cadilhac
2006-05-29 22:11                                             ` Eli Zaretskii
2006-05-29 22:32                                               ` Michaël Cadilhac
2006-05-30 12:11                                         ` Kim F. Storm
2006-05-30 12:42                                           ` Michaël Cadilhac
2006-05-30 14:26                                             ` Kim F. Storm
2006-05-30 15:13                                               ` Michaël Cadilhac
2006-06-01 14:06                                                 ` Kim F. Storm
2006-06-01 14:20                                                   ` Michaël Cadilhac
2006-06-01 14:29                                                     ` Kim F. Storm
2006-06-01 16:05                                                       ` Michaël Cadilhac
2006-06-02  7:46                                                         ` Kim F. Storm
2006-06-01 16:41                                                     ` Agustin Martin
2006-06-01 16:55                                                       ` Michaël Cadilhac
2006-05-29 23:07                               ` Agustin Martin
2006-05-25 23:52       ` delete-process bug (was: Ispell loads dict twice.) Kim F. Storm
2006-06-06 20:45   ` Ispell loads dict twice Michaël Cadilhac
2006-06-09 13:02     ` Kim F. Storm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m34pz9s0ju.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=agustin.martin@hispalinux.es \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.