Re: [PATCH] autorevert.el -- revert fix for Windows platform

[storm@cua.dk (Kim F. Storm)]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> For the release, I'd say Jari's patch is good enough!
>
>> I'm not sure, do we really expect buffer-size to be the same as the number
>> of bytes in the file, potentially in the presence of multibyte characters?
>> This change is quite likely to break things if that assumption is
>> not correct.

>
> Duh, I didn't even look at the patch.  So no clearly the patch is
> unacceptable as is.  But the principle of checking whether the file changes
> size is the thing I agreed to.

Me too.

I didn't think deeply about the implications of using (buffer-size)
directly, but what about using (position-bytes (buffer-size)) instead?

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk