From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tom Tromey Newsgroups: gmane.emacs.devel Subject: Re: Patch for fields of `struct buffer' Date: Tue, 08 Feb 2011 14:21:02 -0700 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1297200387 31842 80.91.229.12 (8 Feb 2011 21:26:27 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 8 Feb 2011 21:26:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 08 22:26:22 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pmv4n-0001PJ-QB for ged-emacs-devel@m.gmane.org; Tue, 08 Feb 2011 22:26:21 +0100 Original-Received: from localhost ([127.0.0.1]:60077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pmv4n-0006VF-65 for ged-emacs-devel@m.gmane.org; Tue, 08 Feb 2011 16:26:21 -0500 Original-Received: from [140.186.70.92] (port=43970 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pmv08-0003k6-BU for emacs-devel@gnu.org; Tue, 08 Feb 2011 16:21:34 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pmuzi-00043I-Db for emacs-devel@gnu.org; Tue, 08 Feb 2011 16:21:10 -0500 Original-Received: from mx1.redhat.com ([209.132.183.28]:21410) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pmuzi-000434-6U for emacs-devel@gnu.org; Tue, 08 Feb 2011 16:21:06 -0500 Original-Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p18LL5k0011187 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Feb 2011 16:21:05 -0500 Original-Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p18LL4Sj025495; Tue, 8 Feb 2011 16:21:04 -0500 Original-Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p18LL3Ws030579; Tue, 8 Feb 2011 16:21:03 -0500 Original-Received: by opsy.redhat.com (Postfix, from userid 500) id 19B4237817D; Tue, 8 Feb 2011 14:21:03 -0700 (MST) X-Attribution: Tom In-Reply-To: (Stefan Monnier's message of "Tue, 08 Feb 2011 16:02:58 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135776 Archived-At: Stefan> Please use an enum type rather than a char for the "type" field. Done. Stefan> I'd have used a singly-linked list or a "xrealloc (twice the size)" Stefan> scheme, to avoid allocating N^2 amount of memory. But I guess it Stefan> doesn't matter for make-docfile. I did the size-doubling thing. Stefan> Better use `switch'. Done. Stefan> The rest looks good, thank you. I am going to commit it once my bootstrap finishes successfully. This may break the Windows build, or other builds. I have no way to test that. I can provide some support for fixing problems, though. Tom