From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Ivan Shmakov <ivan@siamics.net>
Cc: 18550@debbugs.gnu.org
Subject: bug#18550: eww-history-browse may end up calling eww-restore-history in an arbitrary buffer
Date: Wed, 19 Nov 2014 18:25:57 +0100 [thread overview]
Message-ID: <m34mtvp0ey.fsf@stories.gnus.org> (raw)
In-Reply-To: <87zjbn5sxj.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 19 Nov 2014 11:30:16 +0000")
Ivan Shmakov <ivan@siamics.net> writes:
> I see no reason to abuse quit-window for what’s essentially
> switching to a buffer to edit one. That is: the
> eww-restore-history call right after quit-window edits the
> /current/ buffer. Thus, it indeed makes sense to explicitly use
> set-buffer before that. (Or to wrap the call in
> with-current-buffer, anyway.)
>
> Moreover, vc.el already uses a dedicated buffer-local variable
> for a similar purpose, and so does rcirc.el, and perhaps a few
> more modes out there.
I think you're arguing against yourself here. If this is such a common
thing to do, then something in this setup should provide this
functionality, so that all these modes don't have to implement it again
and again.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2014-11-19 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 21:19 bug#18550: eww-history-browse may end up calling eww-restore-history in an arbitrary buffer Ivan Shmakov
2014-11-13 17:03 ` Lars Magne Ingebrigtsen
2014-11-13 17:14 ` Lars Magne Ingebrigtsen
2014-11-19 11:30 ` Ivan Shmakov
2014-11-19 17:25 ` Lars Magne Ingebrigtsen [this message]
2014-11-25 15:40 ` Ivan Shmakov
2014-12-07 19:38 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34mtvp0ey.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=18550@debbugs.gnu.org \
--cc=ivan@siamics.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.