From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Magne Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 11cf3e9: Implement a new function directory-files-recursively Date: Wed, 10 Dec 2014 05:39:04 +0100 Message-ID: References: <20141209062121.9440.90058@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1418186393 10081 80.91.229.3 (10 Dec 2014 04:39:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2014 04:39:53 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 10 05:39:46 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XyZ3x-0004jK-Jz for ged-emacs-devel@m.gmane.org; Wed, 10 Dec 2014 05:39:45 +0100 Original-Received: from localhost ([::1]:43413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyZ3x-0002RC-8B for ged-emacs-devel@m.gmane.org; Tue, 09 Dec 2014 23:39:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44905) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyZ3p-0002R3-8j for emacs-devel@gnu.org; Tue, 09 Dec 2014 23:39:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XyZ3j-0004jg-Ud for emacs-devel@gnu.org; Tue, 09 Dec 2014 23:39:37 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:36586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XyZ3j-0004ir-NZ for emacs-devel@gnu.org; Tue, 09 Dec 2014 23:39:31 -0500 Original-Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XyZ3J-0003qZ-1P; Wed, 10 Dec 2014 05:39:05 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAD1BMVEUkKBmxtaF2fWNUW0QG BgMO00mwAAACYklEQVQ4jY2U2ZUjIQxFxRIAiA4ApA4AgQOgbfKPaR5le9xnvqaOP1y6aEHSK9qf x7jT4BCvF/rYW1lDeNTvf4DVkJUW6fwFiKhVz7dHy2Le/wVr73syJst9TVG5vUEk4lFCPkhnSukF 4PBoPDJ+uuZMVW/vUORhlJbnYB06fD1g7bhXRhwkzopLeOfcASFGMs5sINrh7368iwCT4iqt4jzP OUF+3BgdoM54xWm5U+jUv+9+ikRatUZfrViWTjS0JD9U9UaP/q3VFc9zKH6aitda0xfde2VX7oVW kDa1ljIAvr7IBy0lMEruwTXRxOGARN5LnrAH2uQsF+TQ9AS417MFACKphHJ5wD+foRFFgCYlDU56 QDPh0y/cDn9HLXdWrYlGzqIA93w9pop4o6KqbJI+wM3bj9gBrbXfwEydjcaJGOTrN+jOzFo6Hu0s jH+C1ujHXGsn+QUoXHZmid6ajUQiuVWMkTCLVLTUPVrLdiMF6Jg6YddSKvy9hRFkAiDsjiFECoqX +CiZs6sEx4bhoofLjzHSksLM8ACwfov9ai5JHwF2zhPFNbv1SBjIGK1LN0HvIYj7gEfYAFubwMNQ VCqoRQDWXhhV61j57jKan4j2yAZFrDV4tuTrQ+10DzkDTmiwDN2UUNdcE/erEVW6ppjJxOIK5BFn FDZUAwlw1iCZkQH2QCGqxQN2YXQPAWo45z32tsRLH5DMFChnnkgBa031pSgstHTP8WWH9vYVCumP NnbQE+f5XGDfFamhMRo9vuxPsFBurhQkvs+/PwA+c11B3/ZDXp8MCGN+zP98ZPb/gT96eqshRvaL 6AAAAABJRU5ErkJggg== X-Now-Playing: Various's _The Wire Tapper 31_: "Heidi Mortensen - Dele Af Kroppen" X-Hashcash: 1:23:141210:monnier@iro.umontreal.ca::5pjQ9/BbfOq4dnog:0000000000000000000000000000000000000CZ7l X-Hashcash: 1:23:141210:emacs-devel@gnu.org::T11XAdivQ/RUeCen:000000000000000000000000000000000000000000LFNR In-Reply-To: (Stefan Monnier's message of "Tue, 09 Dec 2014 19:42:58 -0500") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-MailScanner-ID: 1XyZ3J-0003qZ-1P MailScanner-NULL-Check: 1418791145.4443@McvqnM/dvP8WF8guLkBvJw X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.224.195 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:179620 Archived-At: Stefan Monnier writes: > Eric's version allows precise control those subdirectories in which we > want to recurse and those in which we don't. This is a very > important functionality. Oh, I missed that. It was buried rather far down in the doc string... > And here you make the same mistake that I already pointed out to Eric: > using directory-files followed by file-directory-p on each file is about > 10 times slower than using file-name-all-completions and checking the > presence of a final / instead. I peeked quickly at --- (file-name-all-completions FILE DIRECTORY) Return a list of all completions of file name FILE in directory DIRECTORY. These are all file names in directory DIRECTORY which begin with FILE. --- and it was not immediately obvious to me how this would help here. Can FILE be "" to get all files in a directory? I guess so. I've now rewritten the function to use that instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no