From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thomas Fitzsimmons Newsgroups: gmane.emacs.devel Subject: Re: Updated eudcb-mab.el Date: Sat, 21 Feb 2015 19:40:59 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1424565680 27751 80.91.229.3 (22 Feb 2015 00:41:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Feb 2015 00:41:20 +0000 (UTC) Cc: John Wiegley , emacs-devel@gnu.org To: Danie Roux Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 22 01:41:10 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YPKbe-0007uJ-3U for ged-emacs-devel@m.gmane.org; Sun, 22 Feb 2015 01:41:10 +0100 Original-Received: from localhost ([::1]:38127 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPKbd-0001ZE-7A for ged-emacs-devel@m.gmane.org; Sat, 21 Feb 2015 19:41:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPKbZ-0001Y6-VJ for emacs-devel@gnu.org; Sat, 21 Feb 2015 19:41:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YPKbV-0006eb-UR for emacs-devel@gnu.org; Sat, 21 Feb 2015 19:41:05 -0500 Original-Received: from mail-ig0-f173.google.com ([209.85.213.173]:43249) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YPKbV-0006eU-Q0 for emacs-devel@gnu.org; Sat, 21 Feb 2015 19:41:01 -0500 Original-Received: by mail-ig0-f173.google.com with SMTP id a13so11074935igq.0 for ; Sat, 21 Feb 2015 16:41:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=K1q1y03yreSK6zj9hJ6qEsNLVQjzShDIWKo2DYw3WlI=; b=hD162IUO4ED7H7uto5ndqE3HkOfaibDIg9diT1NAT+8cC22YmKaLWqJ+Xxs47V7Pvp OWptL4dhLnIjjZSuyrRb3i26c5RmMrea9OznuSOFaosTnW+wi6K8VTO83aF5R0uzhvy0 Klvp3+yPsWslc4P5OwhgtfhRNYYjR/p1MiFOscBahkTHtfkI43/2XZ+oSbXF59izjNtO 4+odAz81ELhoGY5dxp4s7+Ix2TWSag0TGfb/qfux/aHywP8IoFGCJkoF3qhsgZQAUurC 1B1CYN5E7uLBELdkt19rHlUP935GEGz80aNmT7zuvXFf4eJKH9dO26eJMVhh4Qx1HYu2 Ta7w== X-Gm-Message-State: ALoCoQn/3Wm/6IlkzKHHO0Q8AIIEVMEUOBefDyfs2t2B6TDN3WiLATg+3AsPeIKjWmnAeQSBXg9p X-Received: by 10.42.28.199 with SMTP id o7mr4911321icc.23.1424565660986; Sat, 21 Feb 2015 16:41:00 -0800 (PST) Original-Received: from hp-dv5t (bas11-london14-845480831.dsl.bell.ca. [50.101.3.127]) by mx.google.com with ESMTPSA id 184sm10150177ion.14.2015.02.21.16.41.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 21 Feb 2015 16:41:00 -0800 (PST) In-Reply-To: (Danie Roux's message of "Sat, 21 Feb 2015 17:57:37 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.213.173 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183377 Archived-At: Danie Roux writes: > Thomas Fitzsimmons writes: > >> Danie Roux writes: >> >> [...] >> >>> Please find attached a new version and a sql file. >> >> Thanks. A few more comments: >> >> - `eudc-mab-sqlite3-dump-mac-addressbook' should not be interactive: in >> general I'd like to reduce, or at least not grow, the number of >> interactive entry points into EUDC > > Removed. > >> - there are some blank line additions that don't need to be there > > I'm unsure what you are referring to? When I diff the file you provided with eudcb-mab.el from Emacs master (1cb34285463d2b9050a031a7f9a53d376de5b489), I see these unnecessary whitespace changes: [...] ;;; Code: (require 'eudc) + (require 'executable) [...] @@ -124,9 +150,7 @@ ;;}}} - (eudc-register-protocol 'mab) (provide 'eudcb-mab) - ;;; eudcb-mab.el ends here >>> Thomas Fitzsimmons writes: >>>> Danie Roux writes: >>>>> I've updated eudcb-mab.el to directly query the contacts database, >>>>> instead of using an external application. >>>> >>>> It looks like you're still relying on an external application, sqlite3, >>>> instead of "contacts", right? >>> >>> Yes, thank you for picking that up. By external I meant "no additional >>> software". >> >> OK, I was thinking in terms of "external to Emacs". >> >> It's probably best not to mention OS X in the commentary, just leave it >> at: >> >> ;; This library provides an interface to use the Mac's AddressBook, >> ;; by querying a database file using the external program `sqlite3'. > > Changed it, thank you for the suggestion. OK, this is good to go in. After your copyright assignment is done, there are a few more steps: - rebase the patch onto Emacs master - write a ChangeLog entry - commit locally - send the new patch, formatted by git format-patch Thanks, Thomas