From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daiki Ueno Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Generalize start-process with keyword args Date: Tue, 17 Mar 2015 12:39:51 +0900 Message-ID: References: <87d24d3uwz.fsf-ueno@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426563613 29649 80.91.229.3 (17 Mar 2015 03:40:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 17 Mar 2015 03:40:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 17 04:40:12 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YXiMV-00015K-VA for ged-emacs-devel@m.gmane.org; Tue, 17 Mar 2015 04:40:12 +0100 Original-Received: from localhost ([::1]:52624 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXiMV-0006MR-0b for ged-emacs-devel@m.gmane.org; Mon, 16 Mar 2015 23:40:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXiMI-0006MM-RO for emacs-devel@gnu.org; Mon, 16 Mar 2015 23:39:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YXiMI-0002jd-0B for emacs-devel@gnu.org; Mon, 16 Mar 2015 23:39:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53047) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YXiMH-0002jV-Sm for emacs-devel@gnu.org; Mon, 16 Mar 2015 23:39:57 -0400 Original-Received: from du-a.org ([2001:e41:db5e:fb14::1]:34581 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1YXiMF-0008WM-2W; Mon, 16 Mar 2015 23:39:55 -0400 In-Reply-To: (Stefan Monnier's message of "Mon, 16 Mar 2015 23:13:10 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183940 Archived-At: Stefan Monnier writes: >> I think `:coding' at least needs to be treated specially, because if it >> is omitted, other methods to determine the coding system take place >> (`coding-system-for-{read,write}' and `find-operation-coding-system'). > > Why can't we make it use the same methods when ":coding nil" is specified? That would mean that the user explicitly specified no-conversion here. >From the comment in setup_coding_system, which is used by setup_process_coding_systems: /* Setup coding context CODING from information about CODING_SYSTEM. If CODING_SYSTEM is nil, `no-conversion' is assumed. If CODING_SYSTEM is invalid, signal an error. */ > I always found process-connection-type hard to remember. I think it > should either have been named process-connection-use-pty, or its values > should have been pty/pipe. So I think for :connection-type, it would > make sense to require the use of either `pipe' or `pty' (or nil to use > the default rules). Ah, yes, that's a good idea. Regards, -- Daiki Ueno