From: Thomas Fitzsimmons <fitzsim@fitzsim.org>
To: Fabrice Bauzac-Stehly <libnoon@orange.fr>
Cc: 62721@debbugs.gnu.org, fgunbin@fastmail.fm
Subject: bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches
Date: Mon, 15 May 2023 16:40:12 -0400 [thread overview]
Message-ID: <m34jod9vmb.fsf@fitzsim.org> (raw)
In-Reply-To: <m38rdp9vs4.fsf@fitzsim.org> (Thomas Fitzsimmons's message of "Mon, 15 May 2023 16:36:43 -0400")
Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
> Fabrice Bauzac-Stehly <libnoon@orange.fr> writes:
>
>> Hello Thomas,
>>
>> Thomas Fitzsimmons <fitzsim@fitzsim.org> writes:
>>
>>> Do you mind posting the `eudc-ldap-no-wildcard-attributes' setting you
>>> ended up with? The docstring for that variable doesn't mention
>>> adjusting this as a preference, only LDAP failure workarounds. I
>>> would like to update the docstring with an example, to make your use
>>> case more discoverable.
>>
>> Sure. I have kept the two default items of the list, and added
>> 'samaccountname (the attribute for which I don't want any wildcard). As
>> I've used Customize, it appears like this in my ~/.emacs.d/init.el:
>>
>> '(eudc-ldap-no-wildcard-attributes '(objectclass objectcategory samaccountname))
>
> Thanks, and what field of `eudc-query-form' does that affect?
> "E-Mail"?
I'll just share my proposed patch. Does the documentation change
capture your use case?
Thanks,
Thomas
EUDC: Document disabling default LDAP wildcard expansion
* lisp/net/eudc-vars.el (eudc-ldap-no-wildcard-attributes): Cover
`eudc-query-form' and `eudc-expand-inline' behavior in the
customization docstring. (Bug#62721)
diff --git a/lisp/net/eudc-vars.el b/lisp/net/eudc-vars.el
index 12f5347bd35..b3aa23f5827 100644
--- a/lisp/net/eudc-vars.el
+++ b/lisp/net/eudc-vars.el
@@ -441,7 +441,12 @@ eudc-ldap-no-wildcard-attributes
"LDAP attributes which are always searched for without wildcard character.
This is the list of special dictionary-valued attributes, where
wildcarded search may fail. For example, it fails with
-objectclass in Active Directory servers."
+objectclass in Active Directory servers.
+
+You may not want functions like `eudc-query-form' and
+`eudc-expand-inline' to do LDAP wildcard expansion by default on
+certain fields. If so, add the relevant symbol to this list, for
+example `samaccountname' for the \"E-Mail\" field."
:type '(repeat (symbol :tag "Directory attribute")))
next prev parent reply other threads:[~2023-05-15 20:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-08 7:20 bug#62721: 30.0.50; EUDC: stop adding a wildcard to LDAP searches Fabrice Bauzac-Stehly
2023-04-10 14:29 ` Filipp Gunbin
2023-04-10 19:09 ` Fabrice Bauzac-Stehly
2023-04-10 19:36 ` Filipp Gunbin
2023-04-19 12:48 ` Thomas Fitzsimmons
2023-05-14 19:10 ` Fabrice Bauzac-Stehly
2023-05-15 18:28 ` Thomas Fitzsimmons
2023-05-15 20:15 ` Fabrice Bauzac-Stehly
2023-05-15 20:36 ` Thomas Fitzsimmons
2023-05-15 20:40 ` Thomas Fitzsimmons [this message]
2023-05-15 21:56 ` Thomas Fitzsimmons
2023-05-16 8:24 ` Fabrice Bauzac-Stehly
2023-05-16 8:14 ` Fabrice Bauzac-Stehly
2023-05-16 10:57 ` Thomas Fitzsimmons
2023-05-17 6:12 ` Fabrice Bauzac-Stehly
2023-05-17 11:01 ` Thomas Fitzsimmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34jod9vmb.fsf@fitzsim.org \
--to=fitzsim@fitzsim.org \
--cc=62721@debbugs.gnu.org \
--cc=fgunbin@fastmail.fm \
--cc=libnoon@orange.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.