From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: should search ring contain duplicates?
Date: Thu, 04 May 2006 23:55:28 +0200 [thread overview]
Message-ID: <m33bfpwj3j.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <36938.128.165.123.132.1146758757.squirrel@webmail.lanl.gov> (Stuart D. Herring's message of "Thu, 4 May 2006 09:05:57 -0700 (PDT)")
"Stuart D. Herring" <herring@lanl.gov> writes:
> (defun isearch-update-ring (string &optional regexp)
> "Add STRING to the beginning of the search ring.
> REGEXP says which ring to use."
> (history-push string
> (if regexp 'regexp-search-ring 'search-ring)
> (if regexp regexp-search-ring-max search-ring-max)))
What a piece of art! Thanks!
It shows exactly why add-to-history is the rigth way to go.
And fixes the bug in isearch-update-ring too !
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2006-05-04 21:55 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-03 0:54 should search ring contain duplicates? Drew Adams
2006-05-03 7:27 ` Dan Nicolaescu
2006-05-03 8:26 ` Kim F. Storm
2006-05-03 12:48 ` Juri Linkov
2006-05-03 13:53 ` Kim F. Storm
2006-05-04 10:12 ` Kim F. Storm
2006-05-04 10:29 ` David Kastrup
2006-05-04 12:00 ` Stefan Monnier
2006-05-04 12:19 ` Kim F. Storm
2006-05-04 12:25 ` David Kastrup
2006-05-05 22:14 ` Richard Stallman
2006-05-05 23:55 ` Kim F. Storm
2006-05-06 8:00 ` Eli Zaretskii
2006-05-06 23:36 ` Richard Stallman
2006-05-07 20:41 ` Kim F. Storm
2006-05-04 16:05 ` Stuart D. Herring
2006-05-04 16:23 ` David Kastrup
2006-05-04 16:36 ` Stuart D. Herring
2006-05-04 21:55 ` Kim F. Storm [this message]
2006-05-03 15:04 ` query-replace in isearch (was Re: should search ring contain duplicates?) Dan Nicolaescu
2006-05-03 20:27 ` query-replace in isearch Juri Linkov
2006-05-03 20:43 ` query-replace in isearch (was Re: should search ring contain duplicates?) Richard Stallman
2006-05-11 3:45 ` Richard Stallman
2006-05-11 11:57 ` Juri Linkov
2006-05-11 14:10 ` Kim F. Storm
2006-05-11 21:52 ` Juri Linkov
2006-05-19 3:05 ` Juri Linkov
2006-05-20 22:39 ` Kim F. Storm
2006-05-21 4:27 ` Juri Linkov
2006-05-21 0:55 ` Richard Stallman
2006-05-23 5:17 ` Juri Linkov
2006-05-24 2:18 ` Richard Stallman
2006-05-25 22:47 ` Juri Linkov
2006-05-29 6:39 ` Richard Stallman
2006-05-30 9:28 ` Juri Linkov
2006-05-31 0:40 ` Richard Stallman
2006-05-12 4:15 ` Richard Stallman
2006-05-12 11:14 ` Juri Linkov
2006-05-13 4:52 ` Richard Stallman
2006-05-13 23:13 ` Kim F. Storm
2006-05-14 15:09 ` Richard Stallman
2006-05-14 20:52 ` Kim F. Storm
2006-05-09 20:47 ` should search ring contain duplicates? Juri Linkov
2006-05-10 9:34 ` Kim F. Storm
2006-05-10 22:55 ` Juri Linkov
2006-05-11 10:08 ` Kim F. Storm
2006-05-14 23:29 ` Richard Stallman
2006-05-15 9:54 ` Kim F. Storm
2006-05-16 4:29 ` Richard Stallman
2006-05-16 11:07 ` Kim F. Storm
2006-05-11 11:59 ` C-f in isearch minibuffer (was: should search ring contain duplicates?) Juri Linkov
2006-05-11 14:04 ` C-f in isearch minibuffer Miles Bader
2006-05-11 21:52 ` Juri Linkov
2006-05-12 4:15 ` C-f in isearch minibuffer (was: should search ring contain duplicates?) Richard Stallman
2006-05-12 11:12 ` C-f in isearch minibuffer Juri Linkov
2006-05-13 4:52 ` Richard Stallman
2006-05-03 14:18 ` should search ring contain duplicates? Stefan Monnier
2006-05-03 14:25 ` Kim F. Storm
2006-05-03 14:40 ` Drew Adams
2006-05-03 15:54 ` Drew Adams
2006-05-03 20:27 ` Juri Linkov
2006-05-03 23:08 ` Drew Adams
2006-05-04 14:17 ` Richard Stallman
2006-05-04 15:07 ` Kim F. Storm
2006-05-04 22:44 ` Kim F. Storm
2006-05-05 19:05 ` Richard Stallman
2006-05-05 19:14 ` Drew Adams
2006-05-05 19:25 ` David Kastrup
2006-05-05 20:09 ` Drew Adams
2006-05-06 14:25 ` Richard Stallman
2006-05-05 23:22 ` Juri Linkov
2006-05-05 23:32 ` Kim F. Storm
2006-05-06 2:05 ` Drew Adams
2006-05-03 14:43 ` Dan Nicolaescu
2006-05-04 19:41 ` Richard Stallman
2006-05-03 20:42 ` Richard Stallman
2006-05-03 22:41 ` Dan Nicolaescu
2006-05-04 19:41 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2006-05-14 23:29 Richard Stallman
2006-05-14 23:46 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33bfpwj3j.fsf@kfs-l.imdomain.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.