all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: Emacs allocates unnecessary memory during scrolling
Date: Mon, 16 Oct 2006 17:04:38 +0200	[thread overview]
Message-ID: <m33b9o9u9l.fsf@kfs-l.imdomain.dk> (raw)
In-Reply-To: <ud58sqr05.miyoshi@meadowy.org> (MIYOSHI Masanori's message of "Mon\, 16 Oct 2006 23\:23\:06 +0900")

MIYOSHI Masanori <miyoshi@meadowy.org> writes:

> Emacs 22 on Windows (and probably on other platforms) allocates
> unnecessary memory during scrolling.


Thank you for the bug report.

Chong, can you look at it, as I don't have time to dig into it right now?

Maybe a fix would be to operate with it->glyph_row = NULL as we do
elsewhere to just do "display measurements", but that's not a trivial
change to display_string and friends.


>
> The following opearaion reproduces the problem.
>
> o emacs -q
> o Evaluate (setq scroll-conservatively 10) on the scratch buffer.
> o Type `C-h' to view the HELLO file.
> o Type `C-n' on to scroll the window.
> o Emacs allocates unnecessary memory during scrolling.
>
> Large files which contains multibyte characters should be better
> for reproduction.
>
>
> Findings are:
>
> This changes seems to have revealed the problem.
>> 2006-09-06  Kim F. Storm  <storm@cua.dk>
>> 
>> 	* xdisp.c (pos_visible_p): Remove exact_mode_line_heights_p arg;
>> 	so calculate heights even when pos-visible-in-window-p is called
>> 	with partially = t.  Don't overshoot last_visible_y in move_it_to.
>> 	Return row height and row number in new rowh and vpos args.
>
> In the following call sequences, it->w->ncols_scale_factor is
> incremented a number of times.
>
> In xdisp.c:
> pos_visible_p()
> -> display_mode_line()
> -> display_mode_element() ;; case MODE_LINE_DISPLAY:
> -> display_string()
> -> PRODUCE_GLYPHS()
> -> x_produce_glyphs() ;; RIF
> -> append_glyph() ;; it->glyph_row->used[area]++
> -> IT_EXPAND_MATRIX_WIDTH() ;; it->w->ncols_scale_factor++
>
> In consequence, required_matrix_width() in dispnew.c returns a
> large number.  And adjust_glyph_matrix() in dispnew.c allocates
> unnecessary large memory for glyphs.
>
>
> YAMAMOTO Mitsuharu san says:
>
> In xdisp.c:
>> static int
>> display_mode_line (w, face_id, format)
> snip
>> {
> snip
>>   init_iterator (&it, w, -1, -1, NULL, face_id);
>>   prepare_desired_row (it.glyph_row);
>
> Before prepare_desired_row(), it.glyph_row->enabled_p happens not
> to be 0.  This might be caused by the interruption of redisplay
> during scrolling.
>
> Appending the next code before prepare_desired_row() may fix the
> problem.
>> it.glyph_row->enabled_p = 0;
> But he doesn't know the place is appropriate or not.
>
> --
> MIYOSHI Masanori

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

  reply	other threads:[~2006-10-16 15:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-16 14:23 Emacs allocates unnecessary memory during scrolling MIYOSHI Masanori
2006-10-16 15:04 ` Kim F. Storm [this message]
2006-10-18 23:27   ` Chong Yidong
2006-10-19  9:47     ` Kim F. Storm
2006-10-20 11:55       ` MIYOSHI Masanori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33b9o9u9l.fsf@kfs-l.imdomain.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.