From: joakim@verona.se
To: Eli Zaretskii <eliz@gnu.org>
Cc: Juanma Barranquero <lekktu@gmail.com>,
dmantipov@yandex.ru, emacs-devel@gnu.org
Subject: Re: Note on 109327
Date: Tue, 31 Jul 2012 19:35:35 +0200 [thread overview]
Message-ID: <m33947vno8.fsf@chopper.vpn.verona.se> (raw)
In-Reply-To: <83wr1jeua9.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 31 Jul 2012 20:04:46 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Juanma Barranquero <lekktu@gmail.com>
>> Date: Tue, 31 Jul 2012 15:54:38 +0200
>> Cc: Emacs development discussions <emacs-devel@gnu.org>
>>
>> On Tue, Jul 31, 2012 at 2:38 PM, Dmitry Antipov <dmantipov@yandex.ru> wrote:
>>
>> > Please report possible Windows/NS build errors as soon as possible.
>>
>> fontset.c: In function 'dump_fontset':
>> fontset.c:2119:6: error: 'struct frame' has no member named 'name'
>
> Which has nothing to do with Windows, but with --enable-checking.
>
> This problem, however, is more serious, IMO:
>
> gcc -I. -c -gdwarf-2 -g3 -DEMACSDEBUG -fno-crossjumping -Id:/usr/include/libxml2 -DGLYPH_DEBUG=1 -Demacs=1 -I../lib -I../nt/inc -DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -o oo/i386/w32menu.o w32menu.c
> w32menu.c: In function `w32_menu_show':
> w32menu.c:857: error: structure has no member named `title_'
> makefile:322: recipe for target `oo/i386/w32menu.o' failed
> make[1]: *** [oo/i386/w32menu.o] Error 1
>
> AFAIU, it means that coccinelle made an incorrect replacement.
>
> I fixed both of these in revision 109332.
>
> Btw, can't we have in Emacs a feature that would allow such
> refactoring? The replacements don't seem too complex to me. Adding
> this to Emacs will both allow getting rid of an external tool, and be
> a valuable addition to Emacs abilities. WDYT?
>
http://cedet.sourceforge.net/srecode.shtml
The idea is that the two CEDET tools, Semantic and SRecode can cooperate
to provide such features, I think.
--
Joakim Verona
next prev parent reply other threads:[~2012-07-31 17:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-31 12:38 Note on 109327 Dmitry Antipov
2012-07-31 13:13 ` Dan Nicolaescu
2012-07-31 13:25 ` Dmitry Antipov
2012-07-31 13:33 ` Tom Tromey
2012-07-31 13:50 ` Dmitry Antipov
2012-07-31 21:47 ` Thien-Thi Nguyen
2012-08-01 4:34 ` Dmitry Antipov
2012-07-31 13:54 ` Juanma Barranquero
2012-07-31 17:04 ` Eli Zaretskii
2012-07-31 17:17 ` Juanma Barranquero
2012-07-31 17:35 ` joakim [this message]
2012-07-31 17:56 ` Dmitry Antipov
2012-07-31 17:42 ` Dmitry Antipov
2012-07-31 18:06 ` Refactoring in Emacs (was: Note on 109327) Eli Zaretskii
2012-08-01 4:14 ` Refactoring in Emacs Dmitry Antipov
2012-08-01 11:41 ` Refactoring in Emacs : CEDET Eric M. Ludlam
2012-08-01 14:50 ` Eli Zaretskii
2012-08-01 23:42 ` Eric Ludlam
2012-08-01 22:41 ` Refactoring in Emacs Richard Stallman
2012-08-01 14:05 ` Jason Rumney
2012-07-31 15:16 ` Note on 109327 Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33947vno8.fsf@chopper.vpn.verona.se \
--to=joakim@verona.se \
--cc=dmantipov@yandex.ru \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.