From: Lars Magne Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 3431e82: Ignore directory symlinks in directory-files-recursively
Date: Sun, 14 Dec 2014 10:33:39 +0100 [thread overview]
Message-ID: <m3388iwp70.fsf@stories.gnus.org> (raw)
In-Reply-To: <jwv388iomie.fsf-monnier+emacsdiffs@gnu.org> (Stefan Monnier's message of "Sat, 13 Dec 2014 23:59:57 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> As you pointed out, `file-tree-walk' has the nice property that it can
>> stop recursing based on a predicate, so implementing it on
>> `directory-files-recursively' would not be optimal.
>
> Right, what is needed is to extend directory-files-recursively such that
> it can also use a predicate to decide whether to recurse or not.
file-tree-walk uses the same function for the predicate and for the
... processing function. So that would be something like the patch
included below.
The interface isn't the same, though. I think we should perhaps ignore
the non-lexical case and get rid of the ARGS argument. Supplying a
lexical lambda predicate just makes more sense.
And I don't like passing in the DIR and LEAF separately. To check
whether the argument is a directory, the predicate can just use
`directory-name-p' .
diff --git a/lisp/files.el b/lisp/files.el
index d55ef1a..14be6c2 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -766,11 +766,17 @@ prevented. Directory entries are sorted with string-lessp."
(and (> (length name) 0)
(char-equal (aref name (1- (length name))) ?/)))
-(defun directory-files-recursively (dir match &optional include-directories)
+(defun directory-files-recursively (dir match &optional
+ include-directories predicate)
"Return all files under DIR that have file names matching MATCH (a regexp).
This function works recursively. Files are returned in \"depth first\"
and alphabetical order.
-If INCLUDE-DIRECTORIES, also include directories that have matching names."
+If INCLUDE-DIRECTORIES, also include directories that have matching names.
+
+If PREDICATE, this should be a function that will be called on
+each matching file and on all directories. When called on a
+directory, the predicate should return non-nil if the directory
+should be descended into."
(let ((result nil)
(files nil))
(dolist (file (sort (file-name-all-completions "" dir)
@@ -780,13 +786,17 @@ If INCLUDE-DIRECTORIES, also include directories that have matching names."
(let* ((leaf (substring file 0 (1- (length file))))
(path (expand-file-name leaf dir)))
;; Don't follow symlinks to other directories.
- (unless (file-symlink-p path)
+ (when (and (not (file-symlink-p path))
+ (or (null predicate)
+ (funcall predicate path)))
(setq result (nconc result (directory-files-recursively
path match include-directories))))
(when (and include-directories
(string-match match leaf))
(setq result (nconc result (list path)))))
(when (string-match match file)
+ (when predicate
+ (funcall predicate (expand-file-name file dir)))
(push (expand-file-name file dir) files)))))
(nconc result (nreverse files))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2014-12-14 9:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141212105304.4186.22515@vcs.savannah.gnu.org>
[not found] ` <E1XzNqL-000168-2E@vcs.savannah.gnu.org>
2014-12-12 14:57 ` [Emacs-diffs] master 3431e82: Ignore directory symlinks in directory-files-recursively Stefan Monnier
2014-12-13 15:01 ` Lars Magne Ingebrigtsen
2014-12-14 4:59 ` Stefan Monnier
2014-12-14 9:33 ` Lars Magne Ingebrigtsen [this message]
2014-12-14 14:27 ` Stefan Monnier
2014-12-21 11:57 ` Lars Ingebrigtsen
2014-12-22 3:02 ` Stefan Monnier
2015-01-16 0:08 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3388iwp70.fsf@stories.gnus.org \
--to=larsi@gnus.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.