From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Mon, 09 Feb 2015 12:50:42 +0100 Message-ID: References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> <54CE05A0.2090701@cs.ucla.edu> <54D15CF5.3020809@cs.ucla.edu> <54D2BB6E.1040704@cs.ucla.edu> <54D39782.2070106@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423482690 31253 80.91.229.3 (9 Feb 2015 11:51:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Feb 2015 11:51:30 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 09 12:51:30 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YKmsC-0002pq-Nl for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 12:51:28 +0100 Original-Received: from localhost ([::1]:60451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKmsB-0005iZ-Io for ged-emacs-devel@m.gmane.org; Mon, 09 Feb 2015 06:51:27 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34608) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKmrx-0005hz-IY for emacs-devel@gnu.org; Mon, 09 Feb 2015 06:51:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKmru-00037P-Co for emacs-devel@gnu.org; Mon, 09 Feb 2015 06:51:13 -0500 Original-Received: from mx2.bahnhof.se ([213.80.101.12]:54142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKmru-00037H-5e for emacs-devel@gnu.org; Mon, 09 Feb 2015 06:51:10 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx2-reinject (Postfix) with ESMTP id 446A040D0B; Mon, 9 Feb 2015 12:51:08 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF3) Original-Received: from mf3.bahnhof.se ([127.0.0.1]) by localhost (mf3.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cg04Bd7E7PSo; Mon, 9 Feb 2015 12:51:02 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf3.bahnhof.se (Postfix) with ESMTP id 45FCA3E8CD2; Mon, 9 Feb 2015 12:51:01 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id B48DB52BD75; Mon, 9 Feb 2015 11:51:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 51kDn__BdCkE; Mon, 9 Feb 2015 12:50:43 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id 417CC52BD73; Mon, 9 Feb 2015 12:50:43 +0100 (CET) In-Reply-To: <54D39782.2070106@cs.ucla.edu> (Paul Eggert's message of "Thu, 05 Feb 2015 08:17:06 -0800") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.12 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182676 Archived-At: Paul Eggert writes: > On 02/05/2015 07:54 AM, joakim@verona.se wrote: >> Is it possible to somehow regenerate your patch against whats in the >> xwidget branch now? > > Sorry, my patch was all done by hand. > >> Some questions on the patch though: >> >> - Are you supposed to have a space after # on ifdefed macros? > > Nowadays it's considered nicer to indent there, e.g., see "#ifdef > MAIN_PROGRAM" in lisp.h. Previously we didn't bother and a lot of the > old code is still around, but we're talking new code here.... > >> - you mentioned some names are long, I suppose like >> webkit_osr_mime_type_policy_typedecision_requested_callback >> >> These are generated algorithmically from signal names. Do you have an >> idea for another algorithm? >> > > The names should be static, so there's no need to worry about keeping > them globally unique in the Emacs source code; they need to be unique > only in xwidgets.c. For too-long names like that, how about using the > same name as the g_signal_comment string, replacing "-" with "_"? > E.g., mime_type_policy_decision_requested. > I did this in the xwidget_mvp branch, except I prefixed and postfixed with webkit_*_cb. So I can shorten them a bit further if really needed. -- Joakim Verona