bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional

[joakim@verona.se]

Glenn Morris <rgm@gnu.org> writes:

> Paul Eggert wrote:
>
>> Attached is a proposed patch for this bug. It is not fancy, but it
>> works for me.
>
> Thanks. I wonder if the 'image scrolling method should simply be
> removed, since it doesn't work (to date) and isn't the default.
> Are two methods really needed/useful?

Short version:

It is probably just as well to remove the 'image method.

Long version:

The 'image method was the original scrolling method, which simply makes
a large xwidget and scrolls it using the same method as emacs uses to
scroll images. I liked this method because it was consistent with other
Emacs scrolling.

The 'native method lets webkit do the scrolling.

Originally I used the 'image method myself and added the 'native method
because users wanted it. Now I never use 'image, only 'native.

Perhaps someone still prefers the 'image method though.



>
>> From 879895ad058294eb49d8372ef5dbf053973e45b9 Mon Sep 17 00:00:00 2001
>> From: Paul Eggert <eggert@cs.ucla.edu>
>> Date: Thu, 5 May 2016 22:44:16 -0700
>> Subject: [PATCH] Fix xwidget-webkit-scroll-forward infloop
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> * lisp/xwidget.el (xwidget-webkit-scroll-forward)
>> (xwidget-webkit-scroll-backward): Don't loop if
>> xwidget-webkit-scroll-behavior's value is 'image' (Bug#22465).
>> ---
>>  lisp/xwidget.el | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lisp/xwidget.el b/lisp/xwidget.el
>> index 19f631f..d64237a 100644
>> --- a/lisp/xwidget.el
>> +++ b/lisp/xwidget.el
>> @@ -165,7 +165,7 @@ xwidget-webkit-scroll-forward
>>    (interactive)
>>    (if (eq xwidget-webkit-scroll-behavior 'native)
>>        (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50)
>> -    (xwidget-webkit-scroll-forward)))   ; FIXME infloop!
>> +    (image-forward-hscroll 5)))
>>  
>>  (defun xwidget-webkit-scroll-backward ()
>>    "Scroll webkit backwards.
>> @@ -174,7 +174,7 @@ xwidget-webkit-scroll-backward
>>    (interactive)
>>    (if (eq xwidget-webkit-scroll-behavior 'native)
>>        (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50)
>> -    (xwidget-webkit-scroll-backward))) ; FIXME infloop!
>> +    (image-backward-hscroll 5)))
>>  
>>  
>>  ;; The xwidget event needs to go into a higher level handler

-- 
Joakim Verona