From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#23808: Emacs 25 open-network-stream, make-network-process Date: Thu, 11 Aug 2016 12:42:06 +0200 Message-ID: References: <5767C0A3.9010902@cs.ucla.edu> <4dc79eb4-e2b6-9f33-cf61-af1971e10275@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1470912204 5296 195.159.176.226 (11 Aug 2016 10:43:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Aug 2016 10:43:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: 23808@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 11 12:43:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXnSI-0001BN-O3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Aug 2016 12:43:18 +0200 Original-Received: from localhost ([::1]:47490 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXnSF-0002i2-Jt for geb-bug-gnu-emacs@m.gmane.org; Thu, 11 Aug 2016 06:43:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45240) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXnS5-0002gc-8f for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 06:43:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXnS2-0004jS-Ez for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 06:43:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55315) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXnS2-0004jO-Bp for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 06:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bXnS2-0007xF-74 for bug-gnu-emacs@gnu.org; Thu, 11 Aug 2016 06:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Aug 2016 10:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23808 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23808-submit@debbugs.gnu.org id=B23808.147091217030547 (code B ref 23808); Thu, 11 Aug 2016 10:43:02 +0000 Original-Received: (at 23808) by debbugs.gnu.org; 11 Aug 2016 10:42:50 +0000 Original-Received: from localhost ([127.0.0.1]:53025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXnRq-0007wd-2i for submit@debbugs.gnu.org; Thu, 11 Aug 2016 06:42:50 -0400 Original-Received: from hermes.netfonds.no ([80.91.224.195]:35683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXnRo-0007wW-Rn for 23808@debbugs.gnu.org; Thu, 11 Aug 2016 06:42:49 -0400 Original-Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=stories) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bXnRm-0007qO-38; Thu, 11 Aug 2016 12:42:48 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEX9+cIFAgZOhagCAAH+ /+E4YIWqu6QYHi9B9JI1AAACLUlEQVQ4jW2TTY+jMAyGrVGbPUdolWtlkcw54g9wQD2PojVcESLp mV1l8vfXDtDOflhKad4Hv/mwAQBQ0dmAe1hLIY5wRErE0oECvoASgfCMLyA8rSSSO50wWKSa4VIK TqWqWuLAZTNUEG+cLYMBTaYQBasNZsS2VzTDNwFam1IovDNgs3VQYYaIDDqvtS6SkTAtAi5AAryA 3F7zONS44wCZB1uVTef1GnZ9UOOgKsguxZJTbE/g2E3ADaC35OJ6gPs4XAP2rMJluJKz/Pgb8IQc ppnV/jLcPxi4Xs7Oc3KO5fr/BcTCuvbQBUR8AnS3y7n4jxPIbHFuPkvwB3hzr2K0vQ0ODnB9AWzB 1sWr9xXDV4DuWJtdw1Fyi6t0AIN5BxPXJRMVbdqF34EIctu9xcnrxhuh6xIwqALEt6csWu0bQ1Ka dRnj+ChQOEUR2qYzAadSfq7x4zG+FzDh0r+RSNwrUw44x5lu0wY+3+5LBTojbZkSLjQXDZ0Zgfdq N+mWrdRWoiTAZ6CAllNqcOMRKQFdnjmBfnV7yHHCCaKlrYo8vC40CvCdmSNNVZIWk6OMe4ZxfBUN vy9L6IZP/xG3CnhFrZuaU3/9Z9QC/gn/+fg/0N8PoP/U+ZZ34Ddet7rveqf9dlj5UrJsoBPc+Ea2 XYEpXLxJEO+u2U9TgZYrTwsXtkZ3ZnjNZRikx9Skz9ityO39CfDYvgBfwvnZAEzlBZ4JQtQL8Be+ PkF/mv0G91Xqa8i3xrAAAAAASUVORK5CYII= In-Reply-To: <4dc79eb4-e2b6-9f33-cf61-af1971e10275@cs.ucla.edu> (Paul Eggert's message of "Thu, 11 Aug 2016 02:14:18 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122062 Archived-At: Paul Eggert writes: > This problem was introduced by the recent async changes (Bug#23808). > * src/process.c (Fmake_process): Move USE_SAFE_ALLOCA later, > so that it follows the start_process_unwind unwind-protect. > Set pid to -1 while the process is being created. > (start_process_unwind): Omit unnecessary emacs_abort test. > (connect_network_socket): Simplify use of counts. Unwind > bind_polling_period a bit earlier, so that a remove_process > unwind-protect can be added when needed; this is the heart of > the fix. Undo the unwind-protect just before returning. Seems like the right fix to me, I think? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no