From: Lars Ingebrigtsen <larsi@gnus.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 23808@debbugs.gnu.org
Subject: bug#23808: Emacs 25 open-network-stream, make-network-process
Date: Thu, 11 Aug 2016 12:42:06 +0200 [thread overview]
Message-ID: <m337mblh8h.fsf@gnus.org> (raw)
In-Reply-To: <4dc79eb4-e2b6-9f33-cf61-af1971e10275@cs.ucla.edu> (Paul Eggert's message of "Thu, 11 Aug 2016 02:14:18 -0700")
Paul Eggert <eggert@cs.ucla.edu> writes:
> This problem was introduced by the recent async changes (Bug#23808).
> * src/process.c (Fmake_process): Move USE_SAFE_ALLOCA later,
> so that it follows the start_process_unwind unwind-protect.
> Set pid to -1 while the process is being created.
> (start_process_unwind): Omit unnecessary emacs_abort test.
> (connect_network_socket): Simplify use of counts. Unwind
> bind_polling_period a bit earlier, so that a remove_process
> unwind-protect can be added when needed; this is the heart of
> the fix. Undo the unwind-protect just before returning.
Seems like the right fix to me, I think?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2016-08-11 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 10:08 bug#23808: Emacs 25 open-network-stream, make-network-process Paul Eggert
2016-06-20 12:41 ` Lars Ingebrigtsen
2016-06-20 22:03 ` Paul Eggert
2016-08-11 9:14 ` Paul Eggert
2016-08-11 10:41 ` Lars Ingebrigtsen
2016-08-11 10:42 ` Lars Ingebrigtsen [this message]
2016-08-11 18:26 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m337mblh8h.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=23808@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.