From: Lars Ingebrigtsen <larsi@gnus.org>
To: Tino Calancha <f92capac@gmail.com>
Cc: 22892@debbugs.gnu.org, 22893@debbugs.gnu.org,
Juri Linkov <juri@linkov.net>
Subject: bug#22892: bug#22893: 25.1.50; dired-get-marked-files get all marked
Date: Tue, 25 Jun 2019 16:07:38 +0200 [thread overview]
Message-ID: <m336jx92s5.fsf@gnus.org> (raw)
In-Reply-To: <alpine.LRH.2.20.1603101317100.23082@calancha-ilc.kek.jp> (Tino Calancha's message of "Thu, 10 Mar 2016 13:19:10 +0900 (JST)")
Tino Calancha <f92capac@gmail.com> writes:
>> Since you are changing the function signatures anyway,
>> you could make them consistent between `dired-map-over-marks'
>> and `dired-get-marked-files' by adding an explicit arg `marker-char',
>> i.e. both `dired-get-marked-files' and `dired-map-over-marks'
>> could end with "distinguish-one-marked marker-char all-marks",
>> thus explicitly passing `marker-char' arg down the call chain.
>> Then you'll need `(or marker-char dired-marker-char)' in
>> `dired-marker-regexp' for backward-compatibility. And then also
>> no need to let-bind `dired-marker-char' in `dired-get-marked-files'
>> (it's better to avoid dynamically binding global variables where possible).
>
> It sounds good. Thank you. Implemented in the new patch.
I think the consensus was to apply the patch, but it was never done at
the time, and now it won't apply since this code has changed
substantially in the meantime.
Would it be possible for you to rework the patch and resubmit?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-06-25 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 9:38 bug#22893: 25.1.50; dired-get-marked-files get all marked Tino Calancha
2016-03-04 12:32 ` Lars Ingebrigtsen
2016-03-05 13:14 ` Tino Calancha
2016-03-08 5:18 ` Tino Calancha
2016-03-08 16:01 ` Eli Zaretskii
2016-03-09 15:27 ` Tino Calancha
2016-03-09 23:57 ` Juri Linkov
2016-03-10 4:19 ` Tino Calancha
2019-06-25 14:07 ` Lars Ingebrigtsen [this message]
2020-08-12 11:58 ` bug#22892: " Lars Ingebrigtsen
2016-03-10 4:43 ` Tino Calancha
2016-03-11 0:48 ` Juri Linkov
2016-03-22 9:31 ` bug#22893: dired-marker-regexp use dired-re-mark Tino Calancha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m336jx92s5.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=22892@debbugs.gnu.org \
--cc=22893@debbugs.gnu.org \
--cc=f92capac@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.