From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#17180: [PATCH] eldoc doesn't find docstrings for variable aliases Date: Wed, 26 Jun 2019 16:37:05 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="234409"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Josh , 17180@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jun 26 16:38:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg93z-000ydT-1m for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 16:38:19 +0200 Original-Received: from localhost ([::1]:40728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg93q-0004Zi-69 for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Jun 2019 10:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58253) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hg93j-0004ZD-IT for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hg93i-0002Np-DV for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51379) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hg93i-0002Nh-A0 for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hg93i-0007GT-6E for bug-gnu-emacs@gnu.org; Wed, 26 Jun 2019 10:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Jun 2019 14:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17180 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy fixed Original-Received: via spool by 17180-submit@debbugs.gnu.org id=B17180.156155983227835 (code B ref 17180); Wed, 26 Jun 2019 14:38:02 +0000 Original-Received: (at 17180) by debbugs.gnu.org; 26 Jun 2019 14:37:12 +0000 Original-Received: from localhost ([127.0.0.1]:36685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg92t-0007Et-RI for submit@debbugs.gnu.org; Wed, 26 Jun 2019 10:37:12 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:49936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg92s-0007Ek-5g for 17180@debbugs.gnu.org; Wed, 26 Jun 2019 10:37:10 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg92n-0000mN-MA; Wed, 26 Jun 2019 16:37:08 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEURDw0JBwVMSki7ubdy b24EAwIuLCtErD9UAAACYUlEQVQ4jV1UwXbbIBBcKYnOWjXW2cY8zq3h5ZyifZyj16pnmaj8/yd0 ALl2uyfEMLszywrqN2vfiUitK9FK65OtQRk4Ami4xpcbwBW47T8AlFZizkBPDaXOpBLEK/Z67jtm 2lSctDGFSdzV44gubT4EpSrQd62UmGpurMo5GpJSyuNzLyraXgswdjrXUkrK8cmJfK0ABBB1KWns K3WWt3icS3EtAYyoUEO80kokNEsuHlTDxx6kySl0pUO+byWVQS1I5nFMBA9KjDvNMEtnkJU+8ed0 AYFEvLzMTIQNa816TN0mWcZzknjIDNbZmZMAo8HQBta25OKcYCBEK1HDpZqg0CwLcjGH0oe9J/An fgEFgORP+xBvd6Aw/gLfbwA6kaM2S6xvDihCPKTUjNZcR22dk6TO5loZQ1yp26ys1E4X63VqAx+y XI5a2+Nk0UidhZvW16tlHt5t6Pw6YpJcYH49wXkB+jC51b6V6u7KT6fdII9awcm5SHUNP6tDlTts +ni2Ysq+XXmk7xVoFVqKMSsNuaTfM8cK6OnBuCvr9wzkKbD/9ApxxdViCib7f1waGraHMdxHEd+B XrWYpPcazlpfB9bTENMYtS/TWGcOkX+DheZR+cnfZ64G5YsHfRJV0rnb7QCY51bgBfyIW6o/VNQ0 MzrWfHTRi9nU2mAEMadaaM7XxcsH1kF7qtGKQao9enjN+bXCCIq6AzO/nl3RlFX7HeAMfGYXMRaC ofz3zEuu9Et8VVS0ZcZcWT8nV7RCuknpXmP5AftVqsdj8QA861Aejtw5PB53YFMvRV3UBi/MH7Cj 5g9wELhsAAAAAElFTkSuQmCC In-Reply-To: (Stefan Monnier's message of "Wed, 26 Jun 2019 10:35:42 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:161502 Archived-At: Stefan Monnier writes: >> + /* If we don't have any documentation for this symbol, try to see whether >> + it's an indirect variable and get the documentation from there >> instead. */ >> + if (NILP (tem)) >> + { >> + Lisp_Object indirect = Findirect_variable (symbol); >> + if (!NILP (indirect)) >> + tem = Fget (indirect, prop); >> + } > > In theory documentation-property can be used for any property, so it's > not necessarily specific to variables. IOW I think we should only do > that if `prop` is `variable-documentation`. Ah, makes sense. I'll fix that up... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no