From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: rcirc.el Date: Mon, 10 Oct 2005 11:57:17 +0200 Message-ID: References: <871x2u6ina.fsf@cut.bc.hsia.telus.net> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1128942086 20127 80.91.229.2 (10 Oct 2005 11:01:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 10 Oct 2005 11:01:26 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 10 13:01:16 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EOvO2-0004my-3d for ged-emacs-devel@m.gmane.org; Mon, 10 Oct 2005 13:00:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EOvNz-0001fV-4q for ged-emacs-devel@m.gmane.org; Mon, 10 Oct 2005 07:00:03 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EOuQ1-00077M-PZ for emacs-devel@gnu.org; Mon, 10 Oct 2005 05:58:06 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EOuPw-00076f-LJ for emacs-devel@gnu.org; Mon, 10 Oct 2005 05:58:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EOuPv-00076U-Qq for emacs-devel@gnu.org; Mon, 10 Oct 2005 05:57:59 -0400 Original-Received: from [195.41.46.237] (helo=pfepc.post.tele.dk) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EOuPw-0008Rw-2M for emacs-devel@gnu.org; Mon, 10 Oct 2005 05:58:00 -0400 Original-Received: from kfs-l.imdomain.dk.cua.dk (unknown [80.165.4.124]) by pfepc.post.tele.dk (Postfix) with SMTP id DCEEF2628BD; Mon, 10 Oct 2005 11:57:58 +0200 (CEST) Original-To: Ryan Yeske In-Reply-To: <871x2u6ina.fsf@cut.bc.hsia.telus.net> (Ryan Yeske's message of "Sun, 09 Oct 2005 22:33:13 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43785 Archived-At: Ryan Yeske writes: > Hello, > > Included below is the latest version of rcirc.el, an emacs irc client, > which I am the sole author of. I have submitted copyright assignment > papers, which have been received by the FSF. I would like to offer > this code for inclusion in the next version of emacs, and would > appreciate any feedback. I haven't looked closely at the code, but a few questions come to mind: > ;; rcirc is a lightweight irc client for Emacs A more elaborate "commentary" section in the code would be good. As a minimum it should explain: What is IRC? Does it work only with irc.freenode.net ? > ;; Tested with GNU Emacs 21.3 If you want it to be included with the next release, you should test it with the latest CVS Emacs (to be released as 22.1). But I guess you already did that, as the code will use make-network-process when available ... > (require 'cl) Do you really require cl at runtime or just at compile time? -- Kim F. Storm http://www.cua.dk