* bug#7729: 24.0.50; doc string of `image-mode-fit-frame'
@ 2010-12-24 23:08 Drew Adams
2011-07-14 17:07 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Drew Adams @ 2010-12-24 23:08 UTC (permalink / raw
To: 7729
Doc string:
"Fit the frame to the current image.
This function assumes the current frame has only one window."
But the command actually toggles between fitting the frame to the image
and restoring the previous frame size. This behavior should be
mentioned in the doc. Actually, the command name should reflect this
behavior: `toggle-fit-frame-to-image' or some such.
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-12-20 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags
-Ic:/imagesupport/include'
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#7729: 24.0.50; doc string of `image-mode-fit-frame'
2010-12-24 23:08 bug#7729: 24.0.50; doc string of `image-mode-fit-frame' Drew Adams
@ 2011-07-14 17:07 ` Lars Magne Ingebrigtsen
2011-07-14 20:29 ` Drew Adams
0 siblings, 1 reply; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-07-14 17:07 UTC (permalink / raw
To: Drew Adams; +Cc: 7729
"Drew Adams" <drew.adams@oracle.com> writes:
> Doc string:
>
> "Fit the frame to the current image.
> This function assumes the current frame has only one window."
>
> But the command actually toggles between fitting the frame to the image
> and restoring the previous frame size. This behavior should be
> mentioned in the doc.
I've now fixed this.
> Actually, the command name should reflect this behavior:
> `toggle-fit-frame-to-image' or some such.
No, I don't think that's warranted.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#7729: 24.0.50; doc string of `image-mode-fit-frame'
2011-07-14 17:07 ` Lars Magne Ingebrigtsen
@ 2011-07-14 20:29 ` Drew Adams
0 siblings, 0 replies; 3+ messages in thread
From: Drew Adams @ 2011-07-14 20:29 UTC (permalink / raw
To: 'Lars Magne Ingebrigtsen'; +Cc: 7729
> > Actually, the command name should reflect this behavior:
> > `toggle-fit-frame-to-image' or some such.
>
> No, I don't think that's warranted.
Why not?
The command only does what the current name says 50% of the time. It does what
the new, suggested name says 100% of the time.
Not to mention that `-mode-' here is unnecessary verbiage. The command toggles
frame fitting to an image.
Why not improve things by giving it a name that fits?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-14 20:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-24 23:08 bug#7729: 24.0.50; doc string of `image-mode-fit-frame' Drew Adams
2011-07-14 17:07 ` Lars Magne Ingebrigtsen
2011-07-14 20:29 ` Drew Adams
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.