From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: joakim@verona.se Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Date: Sun, 01 Feb 2015 09:50:35 +0100 Message-ID: References: <20150201003025.18138.95966@vcs.savannah.gnu.org> <54CDC38C.9080701@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1422780672 23478 80.91.229.3 (1 Feb 2015 08:51:12 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 1 Feb 2015 08:51:12 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 01 09:51:12 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YHqFL-0004k8-J0 for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2015 09:51:11 +0100 Original-Received: from localhost ([::1]:43960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHqFK-00029C-QU for ged-emacs-devel@m.gmane.org; Sun, 01 Feb 2015 03:51:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHqFI-00027x-Ak for emacs-devel@gnu.org; Sun, 01 Feb 2015 03:51:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YHqFE-0007Uz-V6 for emacs-devel@gnu.org; Sun, 01 Feb 2015 03:51:08 -0500 Original-Received: from mx1.bahnhof.se ([213.80.101.11]:52323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YHqFE-0007Up-OY for emacs-devel@gnu.org; Sun, 01 Feb 2015 03:51:04 -0500 Original-Received: from localhost (mf.bahnhof.se [213.80.101.20]) by mx1-reinject (Postfix) with ESMTP id D95D540831; Sun, 1 Feb 2015 09:51:02 +0100 (CET) X-Virus-Scanned: by amavisd-new using ClamAV at bahnhof.se (MF1) Original-Received: from mf1.bahnhof.se ([127.0.0.1]) by localhost (mf1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3CpbgYFHG-m4; Sun, 1 Feb 2015 09:50:55 +0100 (CET) Original-Received: from mta.verona.se (h-235-62.a149.priv.bahnhof.se [85.24.235.62]) by mf1.bahnhof.se (Postfix) with ESMTP id 72A7E330AFB; Sun, 1 Feb 2015 09:50:55 +0100 (CET) Original-Received: from localhost (unknown [127.0.0.1]) by mta.verona.se (Postfix) with ESMTP id 3177352B43E; Sun, 1 Feb 2015 08:50:55 +0000 (UTC) X-Virus-Scanned: amavisd-new at verona.se Original-Received: from mta.verona.se ([127.0.0.1]) by localhost (exodia.verona.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AIlwEwdadcWs; Sun, 1 Feb 2015 09:50:35 +0100 (CET) Original-Received: from exodia.verona.se (www.verona.se [192.168.200.15]) by mta.verona.se (Postfix) with ESMTP id C275E52B441; Sun, 1 Feb 2015 09:50:35 +0100 (CET) In-Reply-To: <54CDC38C.9080701@yandex.ru> (Dmitry Gutov's message of "Sun, 01 Feb 2015 08:11:24 +0200") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 213.80.101.11 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182165 Archived-At: Dmitry Gutov writes: > On 02/01/2015 02:30 AM, Joakim Verona wrote: > >> Better changelog for xwidgets > >> diff --git a/ChangeLog b/ChangeLog >> index d7fd76c..7c2e53e 100644 >> --- a/ChangeLog >> +++ b/ChangeLog >> @@ -1,3 +1,7 @@ >> +2015-02-01 Joakim Verona >> + Support for the new Xwidget feature. >> + * configure.ac: > > This ChangeLog entry, as well as ones after it, looks awfully incomplete. > > And shouldn't there be more of them? > > Also, the current standard is that the commit message should contain > the full ChangeLog entry. > > Given the above, maybe you should revert the merge. Then squash all > commits in xwidget into one patch, amend it with proper ChangeLog > entries, and then do the merge. > Perhaps that would be best. On the other hand since I demonstratably don't know what a proper Changelog entry should look like, I would apreciate some help in that regard. -- Joakim Verona