Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets

[joakim@verona.se]

Dmitry Gutov <dgutov@yandex.ru> writes:

> On 02/01/2015 02:30 AM, Joakim Verona wrote:
>
>>      Better changelog for xwidgets
>
>> diff --git a/ChangeLog b/ChangeLog
>> index d7fd76c..7c2e53e 100644
>> --- a/ChangeLog
>> +++ b/ChangeLog
>> @@ -1,3 +1,7 @@
>> +2015-02-01  Joakim Verona  <joakim@verona.se>
>> +	Support for the new Xwidget feature.
>> +	* configure.ac:
>
> This ChangeLog entry, as well as ones after it, looks awfully incomplete.
>
> And shouldn't there be more of them?
>
> Also, the current standard is that the commit message should contain
> the full ChangeLog entry.
>
> Given the above, maybe you should revert the merge. Then squash all
> commits in xwidget into one patch, amend it with proper ChangeLog
> entries, and then do the merge.
>

Perhaps that would be best.

On the other hand since I demonstratably don't know what a proper Changelog entry
should look like, I would apreciate some help in that regard.


-- 
Joakim Verona